Email subject line corrupted in 1.6 group notifications.

[gh0zt]

Since upgrading to v1.6 group notification subject lines are displaying “ and ” where there should be quotes.

I managed to fix it by removing the quotes from this line in the bp-groups-notifications.php and several other places:

$subject = '. $sitename .? ' . sprintf( ( 'You have an invitation to the group: "%s"', 'buddypress' ), $group->name );

To fix it I removed the quotes surrounding the %s

[boonebgorges]

Out of the box config seems to be working OK for me. A couple of questions:

• Did you only upgrade BP? Did you also upgrade WP at the same time?
• Do you use any special plugins for outgoing mail, such as an SMTP plugin?
• Have you tested regular WP emails that may contain quotation marks in the subject lines? Comment moderation email, for example.
• Are you using a custom language pack?

[gh0zt]

Replying to boonebgorges:

Out of the box config seems to be working OK for me. A couple of questions:

• Did you only upgrade BP? Did you also upgrade WP at the same time?
• Do you use any special plugins for outgoing mail, such as an SMTP plugin?
• Have you tested regular WP emails that may contain quotation marks in the subject lines? Comment moderation email, for example.
• Are you using a custom language pack?

Only upgraded BP.
No special plugins for mail.
Haven't tested WP itself.
No custom language pack.

[gh0zt]

I just did a comment test, the WordPress notifications work fine with quotes in subject line so I'm convinced this is a BP issue.

[boonebgorges]

Is it only happening in the subject line, or is the same issue happening in the email content as well?

[gh0zt]

Replying to boonebgorges:

Is it only happening in the subject line, or is the same issue happening in the email content as well?

The content works fine, the codes only appear in the subject line which makes me wonder if different email clients handle it differently.

I'm using gmail just fyi but it was working properly before the update.

[boonebgorges]

I've run a number of diffs and searches on the 1.6 release to see what might have caused such a change, and I can't find anything. But given what you've described, it does sound likely that BP is causing the problem.

Putting in the 1.6.1 milestone for discussion by the dev team. If you manage to do any more debugging and come across any conclusions, please share them here.

[alexbowyer]

I'm having this issue too, as are several others, see this thread:
http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/ascii-characters-in-email/

Seems to have been an issue for a long time, when can we expect a fix?

[johnjamesjacoby]

(In [6586]) Do not call esc_html() on site_name in sign-up email titles. See #4401.

[johnjamesjacoby]

(In [6587]) Revert r6586:

• Do not call esc_html() on site_name in sign-up email titles.
• Do not decode email blogname section of email subjects into HTML entities.
• For all components with notifications, including deprecated files.
• Fixes #4401.

[johnjamesjacoby]

(In [6589]) Revert r6587:

• Introduce bp_get_email_subject() function, to handle formatting of email subjects.
• For all components with notifications, including deprecated files.
• Fixes #4401, better this time.

[DJPaul]

Reopening to fix a typo in r6589

[djpaul]

(In [6640]) Fix variable name typo introduced in r6589 in bp_get_email_subject(). Fixes #4401 again.