Skip to:
Content

#4350 closed defect (bug) (fixed)

Updated forum topics are not displaying the correct action in the activity stream

Reported by: nickharambee Owned by: DJPaul
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.2
Component: Groups Keywords: has-patch commit
Cc:

Description

When I update forum topics the listing in the forum directory (and the page for the topic itself) states the correct time information for the topic/post, i.e. "[user] said [time since post was originally created] ago."

However, in both activity streams it states "[user] started the forum topic [title of topic] in the group... [time forum post was edited], which is of course wrong, as the forum topic was not created at the time it was edited.

I am not sure whether this is supposed to state "[user] edited the forum topic..." This would make sense to me. Otherwise, if it is supposed to state "[user] started the forum topic..." , then it should keep the time of the original post and the correct place in the activity stream based on the time it was created.

I have replicated this issue with more than one forum topic and with the BP default theme. The issue does not occur when editing replies to forum topics, only with the original forum topic. When editing replies everything appears as it did before the edit, so maybe this is how it is meant to work with the original topic too.

Attachments (1)

4350.01.patch (1.2 KB) - added by r-a-y 21 months ago.

Download all attachments as: .zip

Change History (6)

r-a-y21 months ago

comment:1 r-a-y21 months ago

  • Component changed from Core to Groups
  • Keywords has-patch added
  • Severity changed from major to normal
  • Summary changed from Updated forum topics are not displaying the correct time information in the activity stream to Updated forum topics are not displaying the correct action in the activity stream
  • Version changed from 1.5.6 to 1.2

Good catch! The forum topic's activity stream entry updated the time and text, but not the action.

I've attached a patch for this.

Since BP 1.6 is in string freeze, the patch will probably not make the release version of BP 1.6.

Maybe in a minor release of 1.6 or in 1.7 at the latest.

comment:2 DJPaul21 months ago

  • Keywords 1.7-early added
  • Milestone changed from Awaiting Review to Future Release

comment:3 boonebgorges21 months ago

  • Keywords commit added; 1.7-early removed
  • Milestone changed from Future Release to 1.7

comment:4 DJPaul21 months ago

  • Owner set to DJPaul
  • Status changed from new to accepted

comment:5 djpaul21 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [6240]) When group forum topics are modified, update action text on the topic's activity stream entry.

  • In activity stream it states "[user] started the forum topic [title

of topic] in the group… [time forum post was edited]" which is
incorrect as the forum topic was not created at the time it was edited.

  • Fixes #4350, props r-a-y
Note: See TracTickets for help on using tickets.