Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 8 years ago

#4250 closed enhancement (no action required)

Profile - Public / Private Message

Reported by: shanebp's profile shanebp Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Members Keywords: close
Cc: sam3dus@…

Description

On profile pages - 2 suggestions:

  1. Get rid of 'Public Message' button. It has no context in that location. It appears between 2 buttons that do have context, Friendship & Private Message.
  1. It seems rather clunky to have 'Private Message' take you away from the profile you're viewing.

On a custom build, I've changed that to an overlay and member reaction was very positive. I did it all the markup in.../members/single/member-header.php
and then call a function in bp-custom.
Click the button and the overlay appears. In the overlay, click send and the overlay disappears and confirmation appears via bp_core_add_message.

It could be done in a core file, like bp-messages-template/bp_get_send_message_button()
but it needs some simple javascript and putting it all in member-header.php would make it easier to customize & style.

btw - is it of any use for me to include my hack functions, as a pastie link, or are they too obvious to be of any real use ?

Change History (10)

#1 @shanebp
12 years ago

  • Cc sam3dus@… added

#2 @boonebgorges
12 years ago

  • Milestone changed from Awaiting Review to Future Release

btw - is it of any use for me to include my hack functions, as a pastie link, or are they too obvious to be of any real use ?

Anything you're willing to share is always welcome here.

I'm not sure I understand the point about "no context" and 'Public Message'. I do agree that we could do a better job of not jumping between loggedinuser and displayeduser contexts in general.

#3 @shanebp
12 years ago

I'm not sure I understand the point about "no context" and 'Public Message'.

'Public Message' is not specific to the profile being viewed.
Friendship & Private Message are specific to, or targeted to, that Member.

So why have a 'Public Message' button there ? Or anywhere on that Profile?
I'd remove it.

And replace it with a 'Block Member' button - a hack I've done.

The point is to be able to Friend, Message or Block that member without leaving that member's profile,


Last edited 12 years ago by shanebp (previous) (diff)

#4 @shanebp
12 years ago

  • Cc sam3dus@… removed

#5 @shanebp
12 years ago

  • Cc sam3dus@… added

#6 follow-up: @boonebgorges
12 years ago

'Public Message' is not specific to the profile being viewed.

It ought to take you back to your own profile, with @-displayeduser already filled into your activity update box. So if I'm looking at your profile and click 'Send Public Message', I'll be taken back to my profile, with the activity update box prepopulated with "@shanebp".

Do you mean that your Block Member button is a hack, or the Block functionality altogether? I don't recall a Block feature in BP.

#7 in reply to: ↑ 6 @shanebp
12 years ago

Replying to boonebgorges:

'Public Message' is not specific to the profile being viewed.

It ought to take you back to your own profile, with @-displayeduser already filled in...

And it does. If I say that the context is private communication with that user, is that any clearer? It doesn't really matter.

Having to leave the page to send either kind of message is the real issue.

Is there any reason not to use an overlay or hid-able div to show those forms ?
Similar to the way it's already being done for creating Activity comments within the profile?

Do you mean that your Block Member button is a hack, or the Block functionality altogether? I don't recall a Block feature in BP.

The Block / UnBlock functionality altogether - as a hack.

#8 @boonebgorges
12 years ago

Is there any reason not to use an overlay or hid-able div to show those forms ?

No technical reason. In the default theme, I think the goal is to be non-redundant. Having more than one place where you can update your activity stream, for instance, would be a piece of UI redundancy which would mean 2x the work for themers and (potentially) 2x the confusion for users. Same thing with private messaging: the logic is that Messages belong to an individual, and so should be shown under the individual's profile, and nowhere else in the UI.

I don't necessarily think that this is the most wonderful workflow in the world, but I think that this kind of non-redundancy and extensibility is a good reason for why it works the way it does in bp-default.

My sense is that bp-default is nearing its end of life, and we probably won't be doing massive overhauls to its current features. However, when we start doing UI work in the next dev cycle toward bp-default's replacement, I'd love to have your input (as someone running a site with lots of activity) on how a rethought UI should work. I'm not a huge fan of most lightbox UX for input (it's annoying on twitter.com, for instance), but if it were done consistently throughout the theme, I can see how it might be nice. So be sure to stick around and get involved when we start developing for BP 1.7 in the upcoming month or two :)

#9 @shanebp
12 years ago

  • Component changed from Core to Members
  • Keywords close added
  • Severity changed from normal to minor

#10 @DJPaul
8 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing this as it can be customised in theme, per requirements.

Note: See TracTickets for help on using tickets.