Skip to:
Content

BuddyPress.org

Opened 7 years ago

Last modified 6 years ago

#4186 new defect (bug)

'max' not working correctly for bp_has_members

Reported by: jrfoell Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 1.5.5
Component: Members Keywords: needs-refresh reporter-feedback
Cc: justin@…

Description

The 'max' argument is not overriding 'per_page' as it should

Attachments (1)

bp-members-template_patch.diff (609 bytes) - added by jrfoell 7 years ago.
Patch for bp-members-template.php

Download all attachments as: .zip

Change History (6)

@jrfoell
7 years ago

Patch for bp-members-template.php

#1 @DJPaul
7 years ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to Future Release

I think this needs looking at from the perspective of making our template loop arguments function in the same way that WP_Query's do (i.e. if we have a param with the same name as WP does, it would confuse new people less if BP's behaviour of that param matched how WP handled it).

This param has been like this since BP 1.0, so would probably cause backwards compatibility problems if this patch was just dropped in.

#2 @jrfoell
7 years ago

  • Cc justin@… added

Well, WP_Query does not have a 'max' param, but all of the BuddyPress templates do... so maybe there just needs to be some consistency with this parameter among the BuddyPress templates (members, groups, forums), as it does something different in each.

#3 @DJPaul
6 years ago

  • Keywords needs-refresh added; has-patch dev-feedback removed

#4 @jrfoell
6 years ago

Does this go away with the new BP_User_Query?

#5 @boonebgorges
6 years ago

  • Keywords reporter-feedback added

Does this go away with the new BP_User_Query?

I don't think so. In fact, I don't think that BP_User_Query supports a max argument at all. But you should feel free to have a look.

Note: See TracTickets for help on using tickets.