Skip to:
Content

BuddyPress.org

Opened 14 years ago

Last modified 14 years ago

#3992 closed enhancement

Get WP's bumpbot for compressing js/css and incrementing version numbers — at Version 1

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version:
Component: Core Keywords: dev-feedback needs-patch
Cc: nacin

Description (last modified by boonebgorges)

See #WP1952.

WordPress recently introduced the 'bumpbot', a sister script to potbot that regularly checks for changes to .dev.css/.dev.js files, bumps version numbers if necessary to bust browser caches, and compresses them.

nacin has offered to help set up bumpbot for BP. Before we can move forward, we have to regularize our version strings. We're currently using date strings like '20120210', at least in bp-default's main css/js files. WP's opted to use $wp_version throughout (removing manual version specifications when registering scripts, thereby falling back on $wp_version; see http://core.trac.wordpress.org/changeset/19621).

nacin reasonably suggests that we do something similar. Switch our js/css version number to $bp->version, and have the bumpbot autoincrement it here http://buddypress.trac.wordpress.org/browser/trunk/bp-loader.php#L55

No time at the moment to write a patch, but I can look at it later. Any objections?

Change History (1)

#1 @boonebgorges
14 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.