Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#3992 closed enhancement (fixed)

Get WP's bumpbot for compressing js/css and incrementing version numbers

Reported by: boonebgorges Owned by: nacin
Priority: normal Milestone: 1.6
Component: Core Version:
Severity: normal Keywords: dev-feedback needs-patch
Cc: nacin

Description (last modified by boonebgorges)

See ​#WP1952.

WordPress recently introduced the 'bumpbot', a sister script to potbot that regularly checks for changes to .dev.css/.dev.js files, bumps version numbers if necessary to bust browser caches, and compresses them.

nacin has offered to help set up bumpbot for BP. Before we can move forward, we have to regularize our version strings. We're currently using date strings like '20120210', at least in bp-default's main css/js files. WP's opted to use $wp_version throughout (removing manual version specifications when registering scripts, thereby falling back on $wp_version; see ​http://core.trac.wordpress.org/changeset/19621).

nacin reasonably suggests that we do something similar. Switch our js/css version number to $bp->version, and have the bumpbot autoincrement it here ​http://buddypress.trac.wordpress.org/browser/trunk/bp-loader.php#L55. We'll have to pass our version manually to wp_register_script(), of course.

No time at the moment to write a patch, but I can look at it later. Any objections?

Change History (11)

#1 @boonebgorges
15 years ago

  • Description modified (diff)

#2 @boonebgorges
15 years ago

  • Description modified (diff)

#4 @johnjamesjacoby
15 years ago

Works for me.

#5 @johnjamesjacoby
15 years ago

(In [5751]) First pass at replacing manual script versions with bp_get_version(). See #3992.

#6 @johnjamesjacoby
15 years ago

(In [5753]) How much bot could a bumpbot bump if a bumpbot could bump bots. See #3992.

#7 @johnjamesjacoby
15 years ago

  • Milestone Future Release → 1.6

#8 @johnjamesjacoby
15 years ago

  • Owner set to boonebgorges
  • Status new → assigned

boone - are you able to work with Nacin to get this going?

#9 @nacin
15 years ago

  • Owner changed from boonebgorges to nacin
  • Status assigned → accepted

#10 @nacin
15 years ago

  • Resolution → fixed
  • Status accepted → closed

(In [5784]) Compress CSS/JS using the latest version of YUI Compressor, 2.4.7. Removes final semicolon in a CSS declaration block. Previously, committers used 2.4.2. fixes #3992.

#11 @nacin
15 years ago

bumpbot is now operational.

For those curious, /*! marks that a comment should remain after compression, such as a licensing header. The ! is no longer stripped to allow for accidental re-minification to produce the same result.

Note: See TracTickets for help on using tickets.