"Delete Avatar" link should not show up if user did not upload an avatar

[heruputra]

when user delete their avatar, their avatar will change to the default avatar (wp-content/plugins/buddypress/bp-core/images/mystery-man.jpg) and avatar’s delete link is not disappear.

i think “delete link” should disappear when a user use a default avatar.

i mean not “change the default avatar”, but when a user use default avatar, i want the delete avatar link disappear.

because the fact is when user do not upload any avatar and the default avatar appear but delete link is not disappear. its weird if i am the user, because i do not upload any avatar but there are a link to delete avatar in change avatar page

how to solve this problem ?
thank you.

[r-a-y]

Confirmed. Here's a quick patch against trunk.

[DJPaul]

Good patch, it works, but: should we worry about the check failing because there are different filters used in bp_core_avatar_default() and bp_core_avatar_default()? Should we make those filters identical?

[r-a-y]

Yes, that's a valid concern.

I suppose you're referring to the following filters?

• 'bp_core_mysteryman_src'
• 'bp_core_default_avatar_$object' (or rather 'bp_core_default_avatar_user')

[johnjamesjacoby]

(In [5762]) Move bp_get_user_has_avatar() into bp-core-avatars.php and add comparison to bp_core_avatar_default(). Fixes #3977. Props r-a-y, paulgibbs.

[johnjamesjacoby]

Committed working patch. Iterate on trunk if you want to improve it.