Skip to:

Opened 15 years ago

Closed 15 years ago

#391 closed defect (bug) (no action required)

Upgrade problems with current version comparision mechanism

Reported by: burtadsit's profile burtadsit Owned by:
Milestone: Priority: major
Severity: Version:
Component: Keywords:


I was looking to see how the upgrade process works in bp and ran across something. The code defines and version number like so:
define ( 'BP_ACTIVITY_VERSION', '1.0b1.1' ) and the comparison to check if an upgrade is needed is to check to see if we have tables for this component and then get_site_option( 'bp-activity-version' ) < BP_ACTIVITY_VERSION ).

There's an alpha char 'b' in the version number. Is this going to work?

Change History (1)

#1 @apeatling
15 years ago

  • Resolution set to invalid
  • Status changed from new to closed

The version number is treated as numeric, so the 'b' is not considered. Works fine, plus the 'b' is only temporary.

Note: See TracTickets for help on using tickets.