Opened 16 years ago
Closed 16 years ago
#391 closed defect (bug) (no action required)
Upgrade problems with current version comparision mechanism
Reported by: | burtadsit | Owned by: | |
---|---|---|---|
Milestone: | Priority: | major | |
Severity: | Version: | ||
Component: | Keywords: | ||
Cc: |
Description
I was looking to see how the upgrade process works in bp and ran across something. The code defines and version number like so:
define ( 'BP_ACTIVITY_VERSION', '1.0b1.1' )
and the comparison to check if an upgrade is needed is to check to see if we have tables for this component and then get_site_option( 'bp-activity-version' ) < BP_ACTIVITY_VERSION )
.
There's an alpha char 'b' in the version number. Is this going to work?
Note: See
TracTickets for help on using
tickets.
The version number is treated as numeric, so the 'b' is not considered. Works fine, plus the 'b' is only temporary.