bbPress Group Forums fails installation when defines are missing

[r-a-y]

Just encountered this issue where the "DB_CHARSET" define was not defined on a certain WP install's wp-config.php.

So during group forum installation, the generated bb-config.php came prefilled with the following:

define( 'BBDB_CHARSET', 'DB_CHARSET' );

And this generated SQL errors preventing the bbPress tables from being installed.

However, the BuddyPress Forums Setup page says everything is hunky-dory even when the tables were not added to the DB.

Could be an edge-case, but might be good to add proper fallback variables during the creation of bb-config.php.

[boonebgorges]

Looks like bbPress doesn't really *need* to have a charset; I see a couple lines that look like
'charset' => defined( 'BBDB_CHARSET' ) ? BBDB_CHARSET : false

So I think we can probably just get away with wrapping our own define() line in if ( defined( 'DB_CHARSET' ) ). Needs testing, though; we may need to fall back on utf8.

[johnjamesjacoby]

Will be a non-issue going forward with bbPress 2. See #3598.