Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#3733 closed defect (bug) (fixed)

bp_activity_action_mark_favorite() logic problem

Reported by: filosofo's profile filosofo Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.5
Component: Activity Keywords: has-patch
Cc:

Description

When bp_is_activity_component() returns true, bp_activity_action_mark_favorite() returns false.

However, bp_get_activity_favorite_link() builds the favoriting link on bp_get_activity_root_slug(), so any non-ajaxy requests to favorite an activity item will fail.

Attachments (1)

3733.mark-favorite.diff​ (695 bytes) - added by filosofo 14 years ago.

Download all attachments as: .zip

Change History (3)

@filosofo
14 years ago

#1 @johnjamesjacoby
14 years ago

  • Component changed from Core to Activity
  • Milestone changed from Awaiting Review to 1.6

#2 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5297]) Fix activity favoriting action for non-ajax situations. Fixes #3733. Props filosofo.

Note: See TracTickets for help on using tickets.