Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#3584 closed defect (bug) (fixed)

bp_core_set_uri_globals() uses VHOST

Reported by: wpmuguru's profile wpmuguru Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.5
Component: Core Keywords: dev-feedback
Cc:

Description

WP networks that were not upgraded from MU will not have the VHOST constant. In 3.0 VHOST was replaced with SUBDOMAIN_INSTALL.

​http://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-catchuri.php#L281

should be

if ( is_multisite() && ! is_subdomain_install() && empty( $is_root_component ) )

Change History (7)

#1 @wpmuguru
13 years ago

  • Keywords has-patch added
  • Version set to 1.2.9

technically doesn't have a patch attached.

There's no 1.2.10 version to assign to the ticket.

#2 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 1.2.11
  • Version changed from 1.2.9 to 1.2.10

#3 @johnjamesjacoby
13 years ago

(In [5156]) Prevent possible debug notice from checking deprecated local variable. See #3584.

#4 @johnjamesjacoby
13 years ago

  • Keywords dev-feedback added; has-patch removed
  • Milestone changed from 1.2.11 to 1.5.1
  • Version changed from 1.2.10 to 1.5

#5 @wpmuguru
13 years ago

@JJJ - I don't think that check is necessary.

I switched connect.studiopress.com to SUBDOMAIN_INSTALL and it appears to be working fine on the sub sites ex. ​http://connect.studiopress.com/pretty/activity

#6 @boonebgorges
13 years ago

  • Milestone changed from 1.5.1 to 1.6

I'm pretty sure that this block of code doesn't actually do anything. It's intended to modify $bp_uri, but $bp_uri (not being a global variable anymore) is never called after this modification. Still, if it ain't broke... So bumping to 1.6 for proper testing.

#7 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5400]) Remove deprecated reference to VHOST in bp_core_set_uri_globals(). Fixes #3584

Note: See TracTickets for help on using tickets.