Skip to:

Opened 13 years ago

Closed 13 years ago

#3439 closed enhancement (fixed)

require_once instead of require

Reported by: slaffik's profile slaFFik Owned by: slaffik's profile slaFFik
Milestone: 1.5 Priority: normal
Severity: normal Version: 1.5
Component: Toolbar & Notifications Keywords: has-patch


Is it possible to use require_once instead of require for including bp-...-notification.php files?
See patch attached.

I'm adding messages to db in foreach (in BP Default Data), so every time appropriate function "require"s that file - and this produces error, as you understand.

Attachments (1)

messages_notif_require_once.patch (824 bytes) - added by slaFFik 13 years ago.

Download all attachments as: .zip

Change History (6)

#1 @r-a-y
13 years ago

How about loading the notifications file in BP_Messages_Component::includes()?

#2 @boonebgorges
13 years ago

  • Keywords needs-patch added; has-patch removed

Yes, in the other components it's loaded in ::includes. Can I get someone to write that patch?

#3 @boonebgorges
13 years ago

  • Milestone changed from Awaiting Review to 1.5

#4 @slaFFik
13 years ago

  • Keywords has-patch added; needs-patch removed

Boone, I have updated the patch with the new code.
Works on local machine.

#5 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4928]) Load bp-messages-notifications.php in the messages component class instead of inline. Fixes #3439. Props slaFFik and r-a-y.

Note: See TracTickets for help on using tickets.