Audit usage of bp_is_current_component()

[r-a-y]

Attached patch swaps out bp_is_current_component( $component ) with wrapper bp_is_X_component() functions already created in bp-core-template.php.

[johnjamesjacoby]

Looks good.

[boonebgorges]

r-a-y, can I ask you to repatch this? It won't apply cleanly because of the whitespace cleanup.

[r-a-y]

Repatched!

I noticed some other overlap like:
!bp_is_current_component( 'activity' ) || !bp_is_user()

Which is the same as:
!bp_is_user_activity()

So I added them in this patch. There could be more like this in the codebase.

[cnorris23]

Replacing
!bp_is_current_component( 'activity' ) || !bp_is_user()

with
!bp_is_user_activity()

won't work, as bp_is_user_activity() is only a wrapper function for bp_is_current_component( 'activity' ).

[r-a-y]

I added in the bp_is_user() check for bp_is_user_activity() in the patch, so we should be good!

[cnorris23]

Awesome! Good call on my part (hangs his head in shame) :)

[johnjamesjacoby]

Missing bp_is_members_component()

[johnjamesjacoby]

(In [5072]) Audit _is_ functions and _current_component_ functions. Props r-a-y. Fixes #3399.

[johnjamesjacoby]

Note I switched the order of a few things not in this exact patch, putting bp_is_user() ahead of the component checks, etc...

When doing multiple checks in succession, always put the check with the least amount of processing first.

Otherwise, thanks as always for the great patch.

[r-a-y]

Gothca about order in multiple checks!

Caught some typos in r5072. On lines 1180 and 1195, the function names are missing ending parentheses.

[johnjamesjacoby]

Fixed in r5081.