Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3360 closed defect (bug) (fixed)

"Post update" button disabled status doesn't show

Reported by: r-a-y's profile r-a-y Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: normal Version: 1.5
Component: Core Keywords: needs-ui needs-patch


In global.js, need to add the "disabled" class to the "Post update" submit buttons and also handle removing the class when it's re-enabled.

Also, the current input.disabled style lacks visual presence. Needs to be darker.

No time for patch at the moment.

Related: #3165.

Attachments (2)

3360-1.patch (1.8 KB) - added by DJPaul 13 years ago.
3360-2.patch (2.0 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (16)

#1 @DJPaul
13 years ago

We need to update the JS, where we set things like button.prop('disabled', true), to also set a disabled class, as <= IE8 doesn't support input:disabled

13 years ago

#2 @DJPaul
13 years ago

  • Keywords needs-patch needs-ui added
  • Milestone changed from Awaiting Review to 1.3

Since we are using disabled to throttle people submitting updates, the styling should only be applied once the (first) message gets sent sucesfully. I've made this change in the javascript, but the button's background picks up a white? styling from somewhere while it's working.

And we need to come up with new button for disabled, in general.

#3 @boonebgorges
13 years ago

  • Keywords has-patch added; needs-patch removed
  • Severity set to normal

You forgot to remove the 'disabled' class after the 8 second timeout. See 3360-2.patch.

What does "a new button for disabled" mean? Different text? Is this something we need for 1.3?

#4 @DJPaul
13 years ago

When you click on a button, and the AJAX requests happen, the spinner appears (all good). At this point, the visual appearance of the button is that it looks like a white rectangle with a border. In the case of this "8 second button", after the AJAX completes, and the button is not clickable, it looks extremely similar to a button that you *can* click.

#5 @boonebgorges
13 years ago

Right. I tried adding a 'title' attribute so that at least you would have a hover tooltip, but it appears that 'disabled' makes tooltips not work as well. What if we change the button text to "Please wait"? Or to "Please wait (x)" where x is a 87654321 countdown timer?

#6 @DJPaul
13 years ago

I've never really liked the hidden 8 second delay. Let's make it work like Twitter's site: no button visible until you focus in the textarea, then it appears. Then after it submits, the button hides again and focus is removed.

#7 @boonebgorges
13 years ago

Fine by me. You want to patch it, Señor JavaScript?

#8 @DJPaul
13 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#9 @DJPaul
13 years ago

That's done, but the pending / disabled button styles still need updating for the recent changes to the theme's colours.

#11 @boonebgorges
13 years ago

I really like r4814 btw.

#12 @DJPaul
13 years ago

  • Keywords needs-patch added; has-patch removed

Current issue is the a.loading / input.loading CSS. When that's applied to one of the buttons, its background-image selector overrides the button's "background" background.


Left is the live state, middle is loading, right is disabled. I think the disabled button appearance needs some work. I'd almost suggest we come up with a new loading style, and use the current loading style as a new disabled style?

#13 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4886]) Applies new activity stream animations introduced in r4884 to update box when arriving via Send Public Message. Fixes #3360 again

#14 @DJPaul
8 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.