Global and root slug audits

[johnjamesjacoby]

Came across a few incorrect references to normal slugs when they should be using the new root slugs. Also we're still using the globals in quite a few places which means those spots won't get handled by the filters in all places.

Attached patch is for the Activity component, and touches Groups in a few places too.

[johnjamesjacoby]

Activity Slug Audit

[johnjamesjacoby]

(In [4646]) Audit the usage of $bp->activity->slug. See #3325.

[johnjamesjacoby]

(In [4647]) Audit the usage of $bp->friends->slug. See #3325.

[johnjamesjacoby]

(In [4648]) Audit the usage of $bp->groups->slug. See #3325.

[johnjamesjacoby]

(In [4649]) Audit the usage of $bp->groups->root_slug. See #3325.

[johnjamesjacoby]

(In [4650]) Audit the usage of $bp->members->slug and $bp->members->root_slug. See #3325.

[johnjamesjacoby]

(In [4651]) Audit the usage of $bp->blogs->slug and $bp->blogs->root_slug. See #3325.

[johnjamesjacoby]

(In [4652]) Audit the usage of $bp->forums->slug and $bp->forums->root_slug. See #3325.

[boonebgorges]

(In [4677]) Ensure that activity permalinks work by doing the correct bp_is_activity_component() check. See #3325

[boonebgorges]

What's the status here? Can we close the ticket?

[johnjamesjacoby]

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

[boonebgorges]

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

Ugh. That will not be a simple find-and-replace, unless you are way awesomer at regex than I am.

[johnjamesjacoby]

Replying to boonebgorges:

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

Ugh. That will not be a simple find-and-replace, unless you are way awesomer at regex than I am.

I'm not, but my IDE is.

[boonebgorges]

Does that mean you're doing it?

[johnjamesjacoby]

Replying to boonebgorges:

Does that mean you're doing it?

Yes. :)

[djpaul]

(In [4809]) Remove remaining · from templates.
Normalise output of bp_get_member_latest_update() and bp_get_activity_latest_update().
Swapped remaing $bp->activity->root_slug for bp_get_activity_root_slug(). See #3325

[boonebgorges]

(In [4840]) Introduces wrapper functions for retrieving and checking items in bp->action_variables. action_variables audit for xprofile component. See #3325

[boonebgorges]

(In [4842]) Global/slug review in Settings and Messages component. See #3325

[boonebgorges]

(In [4844]) Global/slug audit for groups component. Also regularizes the way that some group forum actions are concatenated. See #3325

[boonebgorges]

(In [4845]) Global/slug audit in Friends component. See #3325

[boonebgorges]

(In [4846]) Global/slug audit in forums component. See #3325

[boonebgorges]

(In [4847]) Global/slug audit in Core and Activity components. Fixes #3325