Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3316 closed defect (bug) (fixed)

What's new textarea & FireFox resize implementation

Reported by: hnla Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords: needs-patch
Cc:

Description

A minor issue.
FF has implemented the resize property for boxes however FF devs have gone insane and set it true for textareas, this can have consequences for layouts due to the nature of resizing working at the dom level to inject inline styling.

The whats-new-textarea group sets the textarea borders not on the actual textarea but on the parent thus if the corner grabhandle is moved horizontally there is no apparent resizing to be seen.

This property is meant - according to the specs - to be defaulted to 'none'

For bp-default it may make sense to add:

textarea {resize: vertical;} || textarea {resize: none;}

as a generic ruleset towards top of the main sheet. setting min/max widths/heights is also an option to prevent layout breakage but these WILL need the !important keyword to override the applied styles FF adds

In case this isn't clear I ranted about this on http://csscreator.com/topic/grabhandled-auto-width-forms

Change History (7)

#1 @DJPaul
8 years ago

Was this tested on trunk or BP 1.2.8/9? I made some subtle tweaks to this text area in r4526 but I'm not sure if it would affect what you're describing.

#2 @DJPaul
8 years ago

  • Keywords reporter-feedback added; what's-new textarea css removed

#3 @cnorris23
8 years ago

  • Severity set to normal

I can replicate this on current trunk and Firefox 5.0.1... I think. You can tell that you are resizing horizontally (as opposed to "no apparent resizing to be seen"), but the textarea ends up underneath the sidebar. I can see how textarea {resize: vertical;} might be helpful.

#4 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Version 1.5 deleted

Confirm/patch against testbp.org and let's close this. Seems like an easy one. Takers?

#5 @johnjamesjacoby
8 years ago

  • Keywords needs-patch added; reporter-feedback removed

#6 @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5048]) Limits textarea resizing to vertical dimension in bp-default. Fixes #3316. Props hnla

#7 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.