Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#3226 closed enhancement (duplicate)

Give descriptive names to components in RSS

Reported by: jefferai's profile jefferai Owned by:
Milestone: 1.8 Priority: normal
Severity: normal Version: 1.2
Component: Activity Keywords:
Cc:

Description

This patch adds a function to provide a common name for some components; this allows RSS feeds for the various Activities types to show different names for the feeds (instead of just "Activity", making it clear to the user that in fact the RSS feeds are different for each activity.

Note that this also changes the return value in bp_activities_member_rss_link to bp_get_activities_member_feed_link from bp_get_activities_member_rss_link. I found this necessary as I was using the BP Follows plugin for the corresponding function there to be called. I did not find anywhere that the original function name was actually being used.

Attachments (1)

fix-showing-appropriate-feed-names.patch (3.4 KB) - added by jefferai 11 years ago.

Download all attachments as: .zip

Change History (5)

#1 @boonebgorges
11 years ago

jefferai - Thanks for the patch. But this is patched against the 1.2 branch, and we're not currently accepting enhancements like this for the 1.2 branch. The way that feed titles are loaded in feeds has changed in the trunk, so I can't apply this patch cleanly. Would you mind checking out a copy of BP trunk http://svn.buddypress.org/trun and repatching?

#2 @DJPaul
11 years ago

  • Component changed from Core to Activity
  • Keywords needs-patch needs-refresh added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Give descriptive names to components to Give descriptive names to components in RSS
  • Version set to 1.2

Since we swap the links, I agree we should swap the RSS feed names/descriptions, too, but we'll need an updated patch for the current trunk.

#3 @r-a-y
8 years ago

  • Keywords needs-patch needs-refresh removed
  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Severity set to normal
  • Status changed from new to closed

This is fixed as of v1.8. See #5020.

#4 @r-a-y
8 years ago

  • Milestone set to 1.8
Note: See TracTickets for help on using tickets.