Skip to:

Opened 13 years ago

Closed 13 years ago

#3152 closed defect (bug) (fixed)

Redirect at the end of upgrade/install wizard does not work

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.5 Priority: critical
Severity: Version: 1.5
Component: Core Keywords: has-patch


In the Finish step of the upgrade wizard (step_finish_save() is the name of the method), you get redirected to the BP general settings page. But this redirect seems to happen too soon, perhaps before the rest of BP is loaded, because the BP panel does not load correctly: on single WP, you get the "You do not have permission to access this page" message (refreshing the page will get you there) and on MS you are redirected to wp-admin/network/?c=1

I'm not sure what the solution is. I'm sure this is a load order issue, but given the way that the upgrade functions are conditionally loaded, I'm not certain that there's a way to give them a different priority with respect to the rest of BP. Another possible fix is to redirect back to the main Dashboard (perhaps with an admin notice that says "BP is set up! Click here to change settings"). Not quite as elegant, but easy, and it won't run into the same problems.

Marking critical because, for UX reasons, it really should be fixed one way or another.

Attachments (1)

3152.001.diff (1.0 KB) - added by cnorris23 13 years ago.

Download all attachments as: .zip

Change History (8)

13 years ago

#1 @cnorris23
13 years ago

This was actually an easy fix. The redirect link was wrong.

#2 @cnorris23
13 years ago

  • Keywords has-patch added

#3 @DJPaul
13 years ago

3152.001.diff doesn't fix the problem, unfortunately.

#4 @cnorris23
13 years ago

What problem are you still having? The only problem I had after the patch was a wp_redirect problem where instead of redirecting to, it would sometimes redirect to which obivously isn't valid. I think that is one of the weird quirks in wp_redirect(). Before the patch, I would get the "You do not have permission to access this page" error, or sometimes the quirk. Was that the same issue you had?

#5 @DJPaul
13 years ago

I was still getting "You do not have permission to access this page", yeah. I'll test again tomorrow in case I mis-applied the patch. (Using WP 3.1.1 and BP trunk)

#6 @cnorris23
13 years ago

Yeah, that's what I tested on too. That's weird. Let me know the results, and I'll poke around more if needed. Patching the redirect link is definitely part of the fix, but it's highly possible it's not the complete fix.

#7 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4258]) Loads BP core files when the setup wizard is finished, so that the redirect completes successfully. Fixes #3152

Note: See TracTickets for help on using tickets.