Hidden/private group activity displaying on public streams

[boonebgorges]

Related: #2293

Activity from hidden groups is shown on some public streams, if the show_hidden flag on.

This arises out of a confusion of what show_hidden is supposed to do. Currently, it does two things:
1) Keeps duplicate content from the main activity stream (ie 'Boone is now friends with Paul' and 'Paul is now friends with Boone', where the second one might be marked hide_sitewide)
2) Keeps content from hidden/private groups out of the stream

The problem is that some of the workarounds to make (1) work the way that it does (see #2293) end up overriding some of the things that (2) is supposed to do. See the bp.org situation as an example.

The real solution is to split hide_sitewide into two different columns.

[DJPaul]

From hnla on a related forum thread:

Can confirm, marking a topic as ‘favourite’ does display this piece of data to site members who are not members of the hidden group, they can navigate to members profile and check members ‘favourite’ listing, they can also mark that item as a ‘favourite’ for their own listing. In all other respects previous issues appear ok and cannot see the hidden group or it’s data elsewhere nor can I, as non joined member see that ‘favourite’ topic in any further detail. WP 3.* / BP 1.2.6

http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/hidden-group-posts-visible-to-all/

[DJPaul]

2678-1.patch is an attempt to stop activity stream favourites in hidden groups going public. It seems to work, but -- as noted in this ticket -- show_hidden is very tricky, it needs a second pair of eyes

[boonebgorges]

DJPaul - I've checked 2678-1.patch and it does appear to be a good fix for the favorites problem that hnla mentions. I would recommend committing this particular change both to trunk and to the 1.2 branch.

This fix doesn't address the core issue of the ticket, which is that hide_sitewide is inconsistently applied, but it is an important fix until a better long-term solution for privacy/visibility is devised.

[djpaul]

(In [4108]) Fix favourited activity items from hidden groups showing in members' profiles. Fixes #2678 (trunk)

[djpaul]

(In [4111]) Fix favourited activity items from hidden groups showing in members' profiles. Fixes #2678 (branch)