Skip to:
Content

Opened 9 years ago

Closed 8 years ago

#2609 closed defect (bug) (fixed)

Latest WordPress 3.1 alpha breaks BuddyPress 1.2.5.2

Reported by: zamoose Owned by: johnjamesjacoby
Milestone: 1.5 Priority: blocker
Severity: Version: 1.2.6
Component: Core Keywords:
Cc: nacin, avbentem

Description

See http://core.trac.wordpress.org/ticket/14729

Upon activating BuddyPress, the entire site dies with the following error:

Fatal error: Call to a member function is_page() on a non-object in [file path]/wp-includes/query.php on line 371

In short, nacin claims that BP is abusing the $wp_query object and thus this error will be present until said abuse is corrected.

Thoughts? Patches? (*crossed fingers*)

Change History (14)

#1 @nacin
9 years ago

  • Cc nacin added

I imagine this is probably fine for 1.2.x as 1.3 should be out around the time of 3.1.

#2 @johnjamesjacoby
9 years ago

Yeh the 1.2 branch is only advertised to work on the 3.0 branch of WP. Still if we can fix this sooner than later is probably best.

Will take a look and see what it will take to fix.

#3 @paulhastings0
9 years ago

@Nacin's cool with it as it is. Shall we punt to get 1.2.6 on the road?

#4 @johnjamesjacoby
9 years ago

  • Milestone changed from 1.2.6 to 1.3
  • Priority changed from normal to critical

Going to end up that way. Too many things tie into this to easily adjust the load order.

When it comes time to do this in 1.3, it will need a few sets of eyes on it.

#5 @johnjamesjacoby
8 years ago

Just switched the load order off of plugins_loaded to init for WordPress Trunk compliance. This will probably break WP 3.0 installs. :sigh:

#6 @johnjamesjacoby
8 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

Load order will need auditing. Assigning to myself since this is my mess to begin with. :)

#7 @jeffsayre
8 years ago

Issues with action and filter hooks can be sniffed out using my WordPress Hook Sniffer plugin. You can learn more about using it here: http://jeffsayre.com/2010/04/29/introducing-wordpress-hook-sniffer-a-developer-plugin/

#9 @avbentem
8 years ago

  • Cc avbentem added

#10 @boonebgorges
8 years ago

I just installed WP r17061 and BP r3542 and I got no errors. Everything is activated and looks all pretty.

Has this been fixed?

#11 @DJPaul
8 years ago

The load order still needs to be corrected. I am surprised if BP trunk and WP trunk work at the moment; see #WP14729 -- that patch is planned to be applied to WP before release so that plugins like BP would become "unbroken." That doesn't change the fact that BP is doing it wrong.

#12 @DJPaul
8 years ago

  • Priority changed from critical to blocker

#13 @DJPaul
8 years ago

See also #1726 when this is fixed.

#14 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3742]) Adjust internal action load orders to stop 'doing it wrong' by moving appropriate actions off plugins_loaded and into init. Fixes #2609 but will need testing; it may have adverse effects on external plugins. Adds missing function_exists checks to bp-default functions.

Note: See TracTickets for help on using tickets.