Skip to:

Opened 14 years ago

Closed 13 years ago

#2544 closed enhancement (wontfix)

[patch] Activity Stream filtering $hidden_sql

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Activity Keywords: has-patch dev-feedback


Please can this patch get into trunk for 1.3. I have previously talked to JJJ about this. It will let me use the 'hide_sitewide' column in the activity stream database to mark entries as spam, allowing integration into Akismet (which I'm going to provide a patch for).

Attachments (3)

wut.diff (763 bytes) - added by DJPaul 14 years ago.
2544-2.diff (744 bytes) - added by DJPaul 13 years ago.
2544-3.patch (1.9 KB) - added by DJPaul 13 years ago.

Download all attachments as: .zip

Change History (11)

14 years ago

#1 @paulhastings0
14 years ago

  • Summary changed from Activity Stream filtering $hidden_sql to [patch] Activity Stream filtering $hidden_sql

#2 @DJPaul
14 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#3 @DJPaul
14 years ago

Is using an "IN" like this slower than "(a.hide_sitewide = 0 OR a.hide_sitewide = 1)"? What's best?

#4 @DJPaul
14 years ago

  • Milestone changed from 1.3 to Awaiting Review

#5 @DJPaul
14 years ago

  • Keywords dev-feedback added

Boone, what are your thoughts on this? The idea was to use this column to allow plugins marking activity entries as spam. For some components which may get custom post type'd, we'd get this "for free", but I think activity streams is likely to not be custom post type'd and therefore has a slightly better justification for this sort of thing. I'm reluctant to add a is_spam column just for this reason, however.

#6 @boonebgorges
13 years ago

The general strategy is fine with me. How about testing hide_sitewide > 0 so that plugins could extend this field even further?

13 years ago

#7 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to 1.3

13 years ago

#8 @DJPaul
13 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

It's a better idea to sort out the duplicate uses of hide_sitewide without adding more confusion to the mix. For the interim, I'll use meta or a JOIN.

Note: See TracTickets for help on using tickets.