Skip to:
Content

BuddyPress.org

Opened 16 years ago

Closed 15 years ago

#2544 closed enhancement (wontfix)

[patch] Activity Stream filtering $hidden_sql

Reported by: DJPaul Owned by: DJPaul
Priority: normal Milestone: 1.5
Component: Activity Version:
Severity: Keywords: has-patch dev-feedback
Cc:

Description

Please can this patch get into trunk for 1.3. I have previously talked to JJJ about this. It will let me use the 'hide_sitewide' column in the activity stream database to mark entries as spam, allowing integration into Akismet (which I'm going to provide a patch for).

Attachments (3)

wut.diff (763 bytes ) - added by DJPaul 16 years ago.
2544-2.diff (744 bytes ) - added by DJPaul 16 years ago.
2544-3.patch (1.9 KB ) - added by DJPaul 16 years ago.

Download all attachments as: .zip

Change History (11)

@DJPaul
16 years ago

#1 @paulhastings0
16 years ago

  • Summary Activity Stream filtering $hidden_sql[patch] Activity Stream filtering $hidden_sql

#2 @DJPaul
16 years ago

  • Owner set to DJPaul
  • Status newassigned

#3 @DJPaul
16 years ago

Is using an "IN" like this slower than "(a.hide_sitewide = 0 OR a.hide_sitewide = 1)"? What's best?

#4 @DJPaul
16 years ago

  • Milestone 1.3Awaiting Review

#5 @DJPaul
16 years ago

  • Keywords dev-feedback added

Boone, what are your thoughts on this? The idea was to use this column to allow plugins marking activity entries as spam. For some components which may get custom post type'd, we'd get this "for free", but I think activity streams is likely to not be custom post type'd and therefore has a slightly better justification for this sort of thing. I'm reluctant to add a is_spam column just for this reason, however.

#6 @boonebgorges
16 years ago

The general strategy is fine with me. How about testing hide_sitewide > 0 so that plugins could extend this field even further?

@DJPaul
16 years ago

#7 @DJPaul
16 years ago

  • Milestone Awaiting Review1.3

@DJPaul
16 years ago

#8 @DJPaul
15 years ago

  • Resolutionwontfix
  • Status assignedclosed

It's a better idea to sort out the duplicate uses of hide_sitewide without adding more confusion to the mix. For the interim, I'll use meta or a JOIN.

Note: See TracTickets for help on using tickets.