Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 12 years ago

#1328 closed defect (bug) (fixed)

Change avatar ID to avatar class [Has Patch]

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.1.3 Priority: trivial
Severity: Version:
Component: Keywords: id, class, avatar, validation, has-patch
Cc:

Description

In BP 1.1+, the user avatar currently uses the ID attribute.
eg.

<img id="user-1-avatar" ... />

However, if a user has multiple activity items in the same stream, the img avatar ID will be duplicated.

I suggest using "class" instead of "id".

Yes! This is trivial, but a little annoying for validation purposes.

Attachments (1)

bp-core-avatars.php.patch (1.3 KB) - added by r-a-y 13 years ago.
Patch for duplicate ID avatar issue

Download all attachments as: .zip

Change History (5)

#1 @r-a-y
13 years ago

  • Keywords has-patch added
  • Summary changed from Change avatar ID to avatar class to Change avatar ID to avatar class [Has Patch]

Just made a quick patch!

@r-a-y
13 years ago

Patch for duplicate ID avatar issue

#2 @apeatling
12 years ago

  • Type changed from enhancement to defect

#3 @apeatling
12 years ago

I think rather than removing the support for a unique ID on avatars, it would be better to change where the ID is being passed, and passing it as a class instead.

#4 @apeatling
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2118]) Moving duplicated avatar ID's to a class instead. Fixes #1328 props r-a-y.

Note: See TracTickets for help on using tickets.