Changeset 9936 for trunk/src/bp-xprofile/bp-xprofile-screens.php

Timestamp:

06/11/2015 06:53:59 AM (10 years ago)

Author:

johnjamesjacoby

Message:

Loaders: Micro-optimizations:

• Add brackets for improved readability
• Only instantiate $bp from buddypress() when used more than once, and after all early return conditions have executed
• Use _slug_ functions where appropriate, and avoid $this->slug references as they do not run filters
• Reduce mulitple calls to the same functions into 1 function call: I.E. bp_core_can_edit_settings()
• Remove BP_Core_Component::setup_nav() method - it's been handled and duplicated by BP_Members_Component for several years now, and only when XProfile is disabled
• Use new bp_get_profile_slug() functions where appropriate
• Use bp_core_number_format() where appropriate
• Avoid duplicate trailingslashit() calls on the same variables
• Rely on canonical menu URLs for all components

This change touches each component's -loader.php file and makes several small optimizations that avoid executing hundreds of function calls that return data (specifically gettext) that never gets used on logged-out users. This results in an approximate 20% reduction in time spent running our full unit test suite in my testing, and also improves site performance for logged-out users.

File:

• trunk/src/bp-xprofile/bp-xprofile-screens.php (modified) (5 diffs)

trunk/src/bp-xprofile/bp-xprofile-screens.php

@@ -53 +53 @@
 function xprofile_screen_edit_profile() {
 
-    if ( !bp_is_my_profile() && !bp_current_user_can( 'bp_moderate' ) )
+    if ( ! bp_is_my_profile() && ! bp_current_user_can( 'bp_moderate' ) ) {
         return false;
-
-    $bp = buddypress();
+    }
 
     // Make sure a group is set.
-    if ( !bp_action_variable( 1 ) )
-        bp_core_redirect( trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/1' ) );
+    if ( ! bp_action_variable( 1 ) ) {
+        bp_core_redirect( trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/1' ) );
+    }
 
     // Check the field group exists
-    if ( !bp_is_action_variable( 'group' ) || !xprofile_get_field_group( bp_action_variable( 1 ) ) ) {
+    if ( ! bp_is_action_variable( 'group' ) || ! xprofile_get_field_group( bp_action_variable( 1 ) ) ) {
         bp_do_404();
         return;
@@ -78 +78 @@
 
         // Check we have field ID's
-        if ( empty( $_POST['field_ids'] ) )
-            bp_core_redirect( trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/' . bp_action_variable( 1 ) ) );
+        if ( empty( $_POST['field_ids'] ) ) {
+            bp_core_redirect( trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . bp_action_variable( 1 ) ) );
+        }
 
         // Explode the posted field IDs into an array so we know which
@@ -181 +182 @@
 
             // Redirect back to the edit screen to display the updates and message
-            bp_core_redirect( trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/' . bp_action_variable( 1 ) ) );
+            bp_core_redirect( trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . bp_action_variable( 1 ) ) );
         }
     }
@@ -212 +213 @@
 
     // Bail if not the correct screen
-    if ( !bp_is_my_profile() && !bp_current_user_can( 'bp_moderate' ) )
+    if ( ! bp_is_my_profile() && ! bp_current_user_can( 'bp_moderate' ) ) {
         return false;
+    }
 
     // Bail if there are action variables
@@ -223 +225 @@
     $bp = buddypress();
 
-    if ( ! isset( $bp->avatar_admin ) )
+    if ( ! isset( $bp->avatar_admin ) ) {
         $bp->avatar_admin = new stdClass();
+    }
 
     $bp->avatar_admin->step = 'upload-image';