Changeset 9765 for trunk/src/bp-groups/bp-groups-template.php

Timestamp:

04/17/2015 01:27:06 PM (10 years ago)

Author:

boonebgorges

Message:

Improved plural forms for localizable strings.

Strings that are intended for use only in the case of a single item should not
be bundled with strings intended for use with plurals, as this pattern does not
work with languages that use the singular nominal form for numbers other than
one. See ​https://core.trac.wordpress.org/ticket/28502#comment:23.

This changeset also fixes a few places where a formatted string, rather than a
raw integer, was being passed as the $count value to _n().

Props SergeyBiryukov.
Fixes #6368.

File:

• trunk/src/bp-groups/bp-groups-template.php (modified) (7 diffs)

trunk/src/bp-groups/bp-groups-template.php

@@ -1794 +1794 @@
         $total     = bp_core_number_format( $groups_template->total_group_count );
 
+        if ( 1 == $groups_template->total_group_count ) {
+            $message = __( 'Viewing 1 group', 'buddypress' );
+        } else {
+            $message = sprintf( _n( 'Viewing %1$s - %2$s of %3$s group', 'Viewing %1$s - %2$s of %3$s groups', $groups_template->total_group_count, 'buddypress' ), $from_num, $to_num, $total );
+        }
+
         /**
          * Filters the "Viewing x-y of z groups" pagination message.
@@ -1804 +1810 @@
          * @param string $total    Total amount of groups found.
          */
-        return apply_filters( 'bp_get_groups_pagination_count', sprintf( _n( 'Viewing 1 group', 'Viewing %1$s - %2$s of %3$s groups', $total, 'buddypress' ), $from_num, $to_num, $total ), $from_num, $to_num, $total );
+        return apply_filters( 'bp_get_groups_pagination_count', $message, $from_num, $to_num, $total );
     }
 
@@ -4116 +4122 @@
         $total     = bp_core_number_format( $members_template->total_member_count );
 
+        if ( 1 == $members_template->total_member_count ) {
+            $message = __( 'Viewing 1 member', 'buddypress' );
+        } else {
+            $message = sprintf( _n( 'Viewing %1$s - %2$s of %3$s member', 'Viewing %1$s - %2$s of %3$s groups', $members_template->total_member_count, 'buddypress' ), $from_num, $to_num, $total );
+        }
+
         /**
          * Filters the "Viewing x-y of z members" pagination message.
@@ -4126 +4138 @@
          * @param string $total    Total amount of members found.
          */
-        return apply_filters( 'bp_get_group_member_pagination_count', sprintf( _n( 'Viewing 1 member', 'Viewing %1$s - %2$s of %3$s members', $total, 'buddypress' ), $from_num, $to_num, $total ), $from_num, $to_num, $total );
+        return apply_filters( 'bp_get_group_member_pagination_count', $message, $from_num, $to_num, $total );
     }
 
@@ -5239 +5251 @@
         $total     = bp_core_number_format( $requests_template->total_request_count );
 
+        if ( 1 == $requests_template->total_request_count ) {
+            $message = __( 'Viewing 1 request', 'buddypress' );
+        } else {
+            $message = sprintf( _n( 'Viewing %1$s - %2$s of %3$s request', 'Viewing %1$s - %2$s of %3$s requests', $requests_template->total_request_count, 'buddypress' ), $from_num, $to_num, $total );
+        }
+
         /**
          * Filters pagination count text for group membership requests.
@@ -5246 +5264 @@
          * @param string $value Pagination count text for group membership requests.
          */
-        return apply_filters( 'bp_get_group_requests_pagination_count', sprintf( _n( 'Viewing 1 request', 'Viewing %1$s - %2$s of %3$s requests', $total, 'buddypress' ), $from_num, $to_num, $total ), $from_num, $to_num, $total );
+        return apply_filters( 'bp_get_group_requests_pagination_count', $message, $from_num, $to_num, $total );
     }
 
@@ -5609 +5627 @@
         $total     = bp_core_number_format( $invites_template->total_invite_count );
 
+        if ( 1 == $invites_template->total_invite_count ) {
+            $message = __( 'Viewing 1 invitation', 'buddypress' );
+        } else {
+            $message = sprintf( _n( 'Viewing %1$s - %2$s of %3$s invitation', 'Viewing %1$s - %2$s of %3$s invitations', $invites_template->total_invite_count, 'buddypress' ), $from_num, $to_num, $total );
+        }
+
         /** This filter is documented in bp-groups/bp-groups-template.php */
-        return apply_filters( 'bp_get_groups_pagination_count', sprintf( _n( 'Viewing 1 invitation', 'Viewing %1$s - %2$s of %3$s invitations', $total, 'buddypress' ), $from_num, $to_num, $total ), $from_num, $to_num, $total );
+        return apply_filters( 'bp_get_groups_pagination_count', $message, $from_num, $to_num, $total );
     }