Changeset 9698 for trunk/tests/phpunit/testcases/core/functions.php

Timestamp:

04/05/2015 06:18:13 PM (9 years ago)

Author:

boonebgorges

Message:

Introduce bp_core_get_root_option() and use throughout BP.

Previously, we referenced the $bp->site_options array directly. This causes
problems in cases where these options may be referenced before the array is
initially populated. bp_core_get_root_option() will fetch the requested
value from the array if it's been populated, and will populate it if it has not.

Fixes #6045.

File:

• trunk/tests/phpunit/testcases/core/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/core/functions.php

@@ -522 +522 @@
 
     /**
+     * @group bp_core_get_root_option
+     */
+    public function test_bp_core_get_root_option_with_unpopulated_cache() {
+        // Back up and unset global cache.
+        $old_options = buddypress()->site_options;
+        unset( buddypress()->site_options );
+
+        $this->assertSame( $old_options['avatar_default'], bp_core_get_root_option( 'avatar_default' ) );
+
+        // Clean up.
+        buddypress()->site_options = $old_options;
+    }
+
+    /**
+     * @group bp_core_get_root_option
+     */
+    public function test_bp_core_get_root_option_with_populated_cache() {
+        // Back up and unset global cache.
+        $old_options = buddypress()->site_options;
+        buddypress()->site_options = bp_core_get_root_options();
+        $expected = buddypress()->site_options['avatar_default'];
+
+        $this->assertSame( $expected, bp_core_get_root_option( 'avatar_default' ) );
+    }
+
+    /**
      * @group bp_core_add_root_component
      */