Skip to:
Content

BuddyPress.org

Changeset 9605


Ignore:
Timestamp:
03/07/2015 11:25:35 AM (5 years ago)
Author:
djpaul
Message:

Administration: fix valueless <label> element for the Settings > BuddyPress > Components screen.

Originally caused by a simple typo, but we can enhance this further by making the component name the label for the corresponding check box.
Doing so lets us click/touch the component name to toggle its check box.

Fixes #6284

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-core/admin/bp-core-admin-components.php

    r9555 r9605  
    195195                            <?php endif; ?>
    196196
    197                             <label class="screen-reader-text" for="bp_components[<?php echo esc_attr( $name ); ?>]"><?php sprintf( __( 'Select %s', 'buddypress' ), esc_html( $labels['title'] ) );  ?></label>
    198197                        </th>
    199198                        <td class="plugin-title" style="width: 190px;">
    200199                            <span></span>
    201                             <strong><?php echo esc_html( $labels['title'] ); ?></strong>
     200                            <label for="bp_components[<?php echo esc_attr( $name ); ?>]">
     201                                <strong><?php echo esc_html( $labels['title'] ); ?></strong>
     202                            </label>
     203
    202204                            <div class="row-actions-visible">
    203205
Note: See TracChangeset for help on using the changeset viewer.