Changeset 9369 for trunk/tests/phpunit/testcases/blogs/activity.php

Timestamp:

01/17/2015 04:46:05 AM (10 years ago)

Author:

imath

Message:

Fix notice errors when an activity is generated for a post having no title.

Post types activities are using dynamic action strings when the activity is displayed in the stream and when the activity is saved into the database. In this particular case, once the post is published, we are "faking" an activity object to which we add two extra properties : the post_title and the post_url. To avoid switching blogs too many times, we are saving the post title into an activity meta. To know if we must build the action string for insert or display, we are checking the post_title property of the activity object. When a post is published without a title, the empty() check was not right. Changing for an isset() check prevents the notice errors.

props boonebgorges

Fixes #6119

File:

• trunk/tests/phpunit/testcases/blogs/activity.php (modified) (1 diff)

trunk/tests/phpunit/testcases/blogs/activity.php

@@ -311 +311 @@
 
     /**
+     * @group activity_action
+     * @group bp_blogs_format_activity_action_new_blog_post
+     */
+    public function test_bp_blogs_format_activity_action_new_blog_post_no_title() {
+        if ( is_multisite() ) {
+            return;
+        }
+
+        $bp = buddypress();
+        $activity_actions = $bp->activity->actions;
+        $bp->activity->actions = new stdClass();
+
+        $u = $this->factory->user->create();
+        $p = wp_insert_post( array(
+            'post_author' => $u,
+            'post_title'  => '', // no title: the object of the test
+            'post_status' => 'publish',
+            'post_content' => 'foo bar',
+        ) );
+
+        $user_link = bp_core_get_userlink( $u );
+        $blog_url = get_home_url();
+        $post_url = add_query_arg( 'p', $p, trailingslashit( $blog_url ) );
+        $post_link = '<a href="' . $post_url . '">(no title)</a>';
+
+        // Set activity actions
+        bp_activity_get_actions();
+
+        $a_obj = bp_activity_get( array(
+            'item_id'           => 1,
+            'secondary_item_id' => $p,
+        ) );
+
+        $expected = sprintf( '%s wrote a new post, %s', $user_link, $post_link );
+
+        $this->assertSame( $expected, $a_obj['activities'][0]->action );
+
+        // Reset activity actions
+        $bp->activity->actions = $activity_actions;
+        $bp->activity->track = array();
+    }
+
+    /**
+     * @group activity_action
+     * @group bp_blogs_format_activity_action_new_blog_post
+     */
+    public function test_bp_blogs_format_activity_action_new_blog_post_updated_without_title() {
+        if ( is_multisite() ) {
+            return;
+        }
+
+        $bp = buddypress();
+        $activity_actions = $bp->activity->actions;
+        $bp->activity->actions = new stdClass();
+
+        $u = $this->factory->user->create();
+        $p = wp_insert_post( array(
+            'post_author' => $u,
+            'post_title'  => 'foo',
+            'post_status' => 'publish',
+            'post_content' => 'foo bar',
+        ) );
+
+        $user_link  = bp_core_get_userlink( $u );
+        $blog_url   = get_home_url();
+        $post_url   = add_query_arg( 'p', $p, trailingslashit( $blog_url ) );
+        $post_title = get_the_title( $p );
+        $post_link  = '<a href="' . $post_url . '">' . $post_title . '</a>';
+
+        // Set actions
+        bp_activity_get_actions();
+
+        $a_obj = bp_activity_get( array(
+            'item_id'           => 1,
+            'secondary_item_id' => $p,
+        ) );
+
+        $expected = sprintf( '%s wrote a new post, %s', $user_link, $post_link );
+
+        $this->assertSame( $expected, $a_obj['activities'][0]->action );
+
+        // Update the post by removing its title
+        wp_update_post( array(
+            'ID'         => $p,
+            'post_title' => '',
+        ) );
+
+        // we now expect the (no title) post link
+        $post_link = '<a href="' . $post_url . '">(no title)</a>';
+        $expected = sprintf( '%s wrote a new post, %s', $user_link, $post_link );
+
+        $a_obj = bp_activity_get( array(
+            'item_id'           => 1,
+            'secondary_item_id' => $p,
+        ) );
+
+        $this->assertSame( $expected, $a_obj['activities'][0]->action );
+
+        // Reset activity actions
+        $bp->activity->actions = $activity_actions;
+        $bp->activity->track = array();
+    }
+
+    /**
      * Dopey passthrough method so we can check that the correct values
      * are being passed to the filter