Changeset 8935 for trunk/src/bp-blogs/bp-blogs-functions.php

Timestamp:

08/17/2014 06:11:43 PM (10 years ago)

Author:

boonebgorges

Message:

Improvements to bp_blogs_total_blogs_for_user()

• Don't bother to check the cache or perform DB queries for users who are not logged in
• Do a strict type check when checking the cache, to ensure that a cached value of 0 does not result in an unnecessary database hit

Fixes #5815

Props wpdennis, r-a-y

File:

• trunk/src/bp-blogs/bp-blogs-functions.php (modified) (2 diffs)

trunk/src/bp-blogs/bp-blogs-functions.php

@@ -1137 +1137 @@
  * Get the total number of blogs being tracked by BP for a specific user.
  *
+ * @since BuddyPress (1.2.0)
+ *
  * @param int $user_id ID of the user being queried. Default: on a user page,
  *        the displayed user. Otherwise, the logged-in user.
@@ -1142 +1144 @@
  */
 function bp_blogs_total_blogs_for_user( $user_id = 0 ) {
-
-    if ( empty( $user_id ) )
+    if ( empty( $user_id ) ) {
         $user_id = ( bp_displayed_user_id() ) ? bp_displayed_user_id() : bp_loggedin_user_id();
-
-    if ( !$count = wp_cache_get( 'bp_total_blogs_for_user_' . $user_id, 'bp' ) ) {
+    }
+
+    // no user ID? do not attempt to look at cache
+    if ( empty( $user_id ) ) {
+        return 0;
+    }
+
+    $count = wp_cache_get( 'bp_total_blogs_for_user_' . $user_id, 'bp' );
+    if ( false === $count ) {
         $count = BP_Blogs_Blog::total_blog_count_for_user( $user_id );
         wp_cache_set( 'bp_total_blogs_for_user_' . $user_id, $count, 'bp' );