Changeset 8175

Timestamp:

03/27/2014 06:20:37 PM (11 years ago)

Author:

boonebgorges

Message:

Don't allow a user to favorite a single activity item more than once.

Fixes #5478

Location:

trunk

Files:

• bp-activity/bp-activity-functions.php (modified) (1 diff)
• tests/testcases/activity/functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-functions.php

@@ -407 +407 @@
         $user_id = bp_loggedin_user_id();
 
-    // Update the user's personal favorites
-    $my_favs   = bp_get_user_meta( $user_id, 'bp_favorite_activities', true );
+    $my_favs = bp_get_user_meta( $user_id, 'bp_favorite_activities', true );
+    if ( empty( $my_favs ) || ! is_array( $my_favs ) ) {
+        $my_favs = array();
+    }
+
+    // Bail if the user has already favorited this activity item
+    if ( in_array( $activity_id, $my_favs ) ) {
+        return false;
+    }
+
+    // Add to user's favorites
     $my_favs[] = $activity_id;
 

trunk/tests/testcases/activity/functions.php

@@ -696 +696 @@
     }
 
+    /**
+     * @group favorites
+     * @group bp_activity_add_user_favorite
+     */
+    public function test_add_user_favorite_already_favorited() {
+        $u = $this->create_user();
+        $a = $this->factory->activity->create();
+
+        bp_activity_add_user_favorite( $a, $u );
+
+        $this->assertFalse( bp_activity_add_user_favorite( $a, $u ) );
+        $this->assertSame( array( $a ), bp_activity_get_user_favorites( $u ) );
+        $this->assertEquals( 1, bp_activity_get_meta( $a, 'favorite_count' ) );
+    }
+
     public function check_activity_caches() {
         foreach ( $this->acaches as $k => $v ) {