Changeset 8176

Timestamp:

03/27/2014 07:04:30 PM (13 years ago)

Author:

r-a-y

Message:

Notifications: Invalidate cache when a notification is updated.

Object caching was added to the notifications component in r7813.
However, the cached item was not invalidated whenever a notification
is updated (either by using one of the marked as read functions or via
using the BP_Notifications_Notification::update() method).

This commit invalidates the cache directly in the update() class
method and adds a unit test.

See #5377

Location:

trunk

Files:

• bp-notifications/bp-notifications-classes.php (modified) (1 diff)
• tests/testcases/notifications/functions.php (modified) (1 diff)

trunk/bp-notifications/bp-notifications-classes.php

@@ -662 +662 @@
                 $where  = self::get_query_clauses( $where_args  );
 
+                // make sure we delete the notification cache for the user on update
+                if ( ! empty( $where_args['user_id'] ) ) {
+                        wp_cache_delete( 'all_for_user_' . $where_args['user_id'], 'bp_notifications' );
+                }
+
                 return self::_update( $update['data'], $where['data'], $update['format'], $where['format'] );
         }

trunk/tests/testcases/notifications/functions.php

@@ -91 +91 @@
                 $this->assertNotEmpty( bp_notifications_add_notification( $args ) );
         }
+
+        /**
+         * @group bp_notifications_get_unread_notification_count
+         * @group cache
+         */
+        public function test_bp_notifications_get_unread_notification_count_cache() {
+                $u1 = $this->create_user();
+                $u2 = $this->create_user();
+
+                $n1 = $this->factory->notification->create( array(
+                        'component_name'    => 'messages',
+                        'component_action'  => 'new_message',
+                        'item_id'           => 99,
+                        'user_id'           => $u2,
+                        'secondary_item_id' => $u1,
+                        'is_new'            => true,
+                ) );
+
+                // prime cache
+                bp_notifications_get_unread_notification_count( $u2 );
+
+                // mark the created notification as read
+                bp_notifications_mark_notifications_by_item_id( $u2, 99, 'messages', 'new_message', $u1 );
+
+                // now grab the updated notification count
+                $n = bp_notifications_get_unread_notification_count( $u2 );
+
+                // assert
+                $this->assertEquals( 0, $n );
+        }
 }