Changeset 7883 for trunk/tests/testcases/activity/functions.php

Timestamp:

02/14/2014 07:02:16 PM (11 years ago)

Author:

boonebgorges

Message:

Add delete_all support for all _delete_meta() functions

The delete_all parameter allows you to delete all meta items matching the
specified meta_key, regardless of the associated object.

Because our meta delete functions also support the deletion of all metadata
associated with an object (by leaving out the meta_key param), a decision had
to be made regarding the behavior when _delete_meta() is called with delete_all

true and meta_key = false. The most logical (and least destructive) strategy

was deemed to be: force delete_all to false when meta_key is also false. This
ensures that you don't accidentally wipe out all metadata for a component.

See #5400

File:

• trunk/tests/testcases/activity/functions.php (modified) (1 diff)

trunk/tests/testcases/activity/functions.php

@@ -337 +337 @@
     /**
      * @group activitymeta
+     * @group bp_activity_delete_meta
+     */
+    public function test_bp_activity_delete_meta_with_delete_all_but_no_meta_key() {
+        // With no meta key, don't delete for all items - just delete
+        // all for a single item
+        $a1 = $this->factory->activity->create();
+        $a2 = $this->factory->activity->create();
+        bp_activity_update_meta( $a1, 'foo', 'bar' );
+        bp_activity_update_meta( $a1, 'foo1', 'bar1' );
+        bp_activity_update_meta( $a2, 'foo', 'bar' );
+        bp_activity_update_meta( $a2, 'foo1', 'bar1' );
+
+        $this->assertTrue( bp_activity_delete_meta( $a1, '', '', true ) );
+        $this->assertEmpty( bp_activity_get_meta( $a1 ) );
+        $this->assertSame( 'bar', bp_activity_get_meta( $a2, 'foo' ) );
+        $this->assertSame( 'bar1', bp_activity_get_meta( $a2, 'foo1' ) );
+    }
+
+    /**
+     * @group activitymeta
+     * @group bp_activity_delete_meta
+     */
+    public function test_bp_activity_delete_meta_with_delete_all() {
+        // With no meta key, don't delete for all items - just delete
+        // all for a single item
+        $a1 = $this->factory->activity->create();
+        $a2 = $this->factory->activity->create();
+        bp_activity_update_meta( $a1, 'foo', 'bar' );
+        bp_activity_update_meta( $a1, 'foo1', 'bar1' );
+        bp_activity_update_meta( $a2, 'foo', 'bar' );
+        bp_activity_update_meta( $a2, 'foo1', 'bar1' );
+
+        $this->assertTrue( bp_activity_delete_meta( $a1, 'foo', '', true ) );
+        $this->assertEmpty( '', bp_activity_get_meta( $a1, 'foo' ) );
+        $this->assertEmpty( '', bp_activity_get_meta( $a2, 'foo' ) );
+        $this->assertSame( 'bar1', bp_activity_get_meta( $a1, 'foo1' ) );
+        $this->assertSame( 'bar1', bp_activity_get_meta( $a2, 'foo1' ) );
+    }
+    /**
+     * @group activitymeta
      * @group bp_activity_add_meta
      */