Changeset 6241 for trunk/bp-groups/bp-groups-classes.php

Timestamp:

08/07/2012 06:25:03 PM (12 years ago)

Author:

djpaul

Message:

Remove get_global_forum_topic_count_extra_sql filter from get_global_forum_topic_count().

This is done because the filter 'groups_total_public_forum_topic_count'
is used in both groups_total_public_forum_topic_count() and in
get_global_forum_topic_count(). Removing it from the latter per
discussion on #4306 to review

File:

• trunk/bp-groups/bp-groups-classes.php (modified) (1 diff)

trunk/bp-groups/bp-groups-classes.php

@@ -646 +646 @@
             $bp->groups->filter_sql = ' AND t.topic_posts = 1';
 
-        /**
-         * Provide backward-compatibility for the groups_total_public_forum_topic_count SQL filter. 
-         * Developers: DO NOT use this filter. It will be removed in BP 1.7. Instead, use
-         * get_global_forum_topic_count_extra_sql. See https://buddypress.trac.wordpress.org/ticket/4306
-         */
-        $maybe_extra_sql = apply_filters( 'groups_total_public_forum_topic_count', $bp->groups->filter_sql, $type );
-
-        if ( is_int( $maybe_extra_sql ) )
-            $extra_sql = $bp->groups->filter_sql;
-        else
-            $extra_sql = $maybe_extra_sql;
-
-        // Developers: use this filter instead
+        // https://buddypress.trac.wordpress.org/ticket/4306
         $extra_sql = apply_filters( 'get_global_forum_topic_count_extra_sql', $bp->groups->filter_sql, $type );