Changeset 5899 for trunk/bp-blogs/bp-blogs-functions.php

Timestamp:

03/11/2012 01:41:51 PM (13 years ago)

Author:

boonebgorges

Message:

Rearranges logic in bp_blogs_record_comment() to avoid PHP notices when a post is left by a non-logged-in user. Fixes #4068. Props Mamaduka

File:

• trunk/bp-blogs/bp-blogs-functions.php (modified) (1 diff)

trunk/bp-blogs/bp-blogs-functions.php

@@ -246 +246 @@
         return false;
 
-    // Get the user_id from the comment author email.
-    $user    = get_user_by( 'email', $recorded_comment->comment_author_email );
+    // Get the user by the comment author email.
+    $user = get_user_by( 'email', $recorded_comment->comment_author_email );
+
+    // If user isn't registered, don't record activity
+    if ( empty( $user ) )
+        return false;
+
+    // Get the user_id
     $user_id = (int) $user->ID;
-
-    // If there's no registered user id, don't record activity
-    if ( empty( $user_id ) )
-        return false;
 
     // Get blog and post data