Changeset 4770 for trunk/bp-friends/bp-friends-classes.php

Timestamp:

07/21/2011 10:27:09 PM (14 years ago)

Author:

djpaul

Message:

Tune up 'for' loops. Fixes #2985, props cnorris23 and r-a-y

File:

• trunk/bp-friends/bp-friends-classes.php (modified) (3 diffs)

trunk/bp-friends/bp-friends-classes.php

@@ -99 +99 @@
         $fids = array();
 
-        for ( $i = 0; $i < count($friends); $i++ ) {
+        for ( $i = 0, $count = count( $friends ); $i < $count; ++$i ) {
             if ( $assoc_arr )
                 $fids[] = array( 'user_id' => ( $friends[$i]->friend_user_id == $user_id ) ? $friends[$i]->initiator_user_id : $friends[$i]->friend_user_id );
@@ -281 +281 @@
         $results = $wpdb->get_results($sql);
 
-        for ( $i = 0; $i < count($results); $i++ ) {
+        for ( $i = 0, $count = count( $results ); $i < $count; ++$i ) {
             $fids[] = ( $results[$i]->friend_user_id == $user_id ) ? $results[$i]->initiator_user_id : $results[$i]->friend_user_id;
         }
 
         // remove duplicates
-        if ( count($fids) > 0 )
+        if ( count( $fids ) > 0 )
             return array_flip(array_flip($fids));
         else
@@ -298 +298 @@
 
         $invitable_count = 0;
-        for ( $i = 0; $i < count($friend_ids); $i++ ) {
+        for ( $i = 0, $count = count( $friend_ids ); $i < $count; ++$i ) {
 
             if ( BP_Groups_Member::check_is_member( (int)$friend_ids[$i], $group_id ) )