Changeset 14044 for branches/14.0/src/bp-templates/bp-legacy/buddypress-functions.php

Timestamp:

10/10/2024 07:57:42 PM (9 months ago)

Author:

imath

Message:

Move the invite_status group meta check out of groups_join_group()

[13874] introduced a regression where groups whose creation process is abandoned become unjoinable & or when using the WP BuddyPress CLI to create groups.

To avoid this, we now perform the check higher up the chain, namely in the places in BuddyPress where groups_join_group() is called.

Props boonebgorges, vapvarun.

Fixes #9241 (branch 14.0)
See #9162

File:

• branches/14.0/src/bp-templates/bp-legacy/buddypress-functions.php (modified) (1 diff)

branches/14.0/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1615 +1615 @@
             if ( ! bp_current_user_can( 'groups_join_group', array( 'group_id' => $group->id ) ) ) {
                 esc_html_e( 'Error joining group', 'buddypress' );
+            }
+
+            /*
+             * Ensure that the invite_status key exists, to avoid a group
+             * being joinable when its creation process was interrupted.
+             */
+            if ( ! groups_get_groupmeta( $group->id, 'invite_status' ) ) {
+                esc_html_e( 'Error joining group', 'buddypress' );
+                break;
             }