Changeset 13874 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

05/26/2024 04:56:49 AM (19 months ago)

Author:

imath

Message:

Groups: joining a group needs to wait for group status to be defined

When the group create first step is completed, the group's status has not been defined by the group creator yet and defaults to public. As the group status & the invite status are set once the group create second step is completed, we need to wait for this step to be achieved to let users join the group being created otherwise it would be possible for a user to "pre-join" a private/hidden group. Checking if the invite status is set is the only way to make sure this second step has been completed. If it's not the case, no need to go further in groups_join_group().

Fixes #9162
Closes ​https://github.com/buddypress/buddypress/pull/294

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-functions.php

@@ -662 +662 @@
     $group = bp_get_group( $group );
 
-    if ( empty( $group->id ) ) {
+    /*
+     * When the group create first step is completed, the group's status has not been defined by the
+     * group creator yet and defaults to public. As the group status & the invite status are set once
+     * the group create second step is completed, we need to wait for this step to be achieved to let
+     * users join the group being created otherwise it would be possible for a user to "pre-join" a
+     * private/hidden group. Checking if the invite status is set is the only way to make sure this
+     * second step has been completed. If it's not the case, no need to go further.
+     */
+    if ( empty( $group->id ) || ! groups_get_groupmeta( $group->id, 'invite_status' ) ) {
         return false;
     }