Changeset 13673

Timestamp:

12/16/2023 10:48:45 AM (3 years ago)

Author:

imath

Message:

BP Template packs: only add the no-js body class in community area

Since [13418] we do not load community assets by default everywhere on the site anymore.

But this commit appears to be incomplete: we also need to avoid adding the no-js body class when not in a community area.

NB: returning false to the 'bp_enqueue_assets_in_bp_pages_only' filter will carry on loading BP Template pack assets everywhere on the site.

Props sabernhardt, emaralive, shawfactor

See #8679
Fixes #9033 (branch 12.0)

Location:

branches/12.0/src/bp-templates

Files:

• bp-legacy/buddypress-functions.php (modified) (1 diff)
• bp-nouveau/buddypress-functions.php (modified) (1 diff)

branches/12.0/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -85 +85 @@
                 add_action( 'bp_enqueue_community_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization
 
-                /** Body no-js Class **************************************************/
-
-                add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
+                /** This filter is documented in bp-core/bp-core-dependency.php */
+                if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+                        // Body no-js class.
+                        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
+                }
 
                 /** Buttons ***********************************************************/

branches/12.0/src/bp-templates/bp-nouveau/buddypress-functions.php

@@ -221 +221 @@
                 remove_action( 'bp_enqueue_community_scripts', 'bp_core_confirmation_js' );
 
-                // Body no-js class.
-                add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
+                /** This filter is documented in bp-core/bp-core-dependency.php */
+                if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+                        // Body no-js class.
+                        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
+                }
 
                 // Ajax querystring.