Changeset 13674

Timestamp:

12/19/2023 11:45:13 PM (10 months ago)

Author:

imath

Message:

Improve BP Directory/page panels in URLs settings tab

• Adds a disabled input to inform about the directory/page permalink.
• Adds a button to open the corresponding page into a new window.

See #9039 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/203

Location:

trunk/src/bp-core/admin

Files:

• bp-core-admin-rewrites.php (modified) (1 diff)
• css/common-rtl.css (modified) (3 diffs)
• css/common.css (modified) (3 diffs)
• js/rewrites-ui.js (modified) (1 diff)

trunk/src/bp-core/admin/bp-core-admin-rewrites.php

@@ -182 +182 @@
                                         <td>
                                             <input type="text" class="code" name="<?php printf( 'components[%d][post_name]', absint( $directory_data->id ) ); ?>" id="<?php echo esc_attr( sprintf( '%s-directory-slug', sanitize_key( $component_id ) ) ); ?>" value="<?php echo esc_attr( $directory_data->slug ); ?>">
+                                        </td>
+                                    </tr>
+                                    <tr>
+                                        <th scope="row">
+                                            <label for="<?php echo esc_attr( sprintf( '%s-directory-url', sanitize_key( $component_id ) ) ); ?>">
+                                                <?php ( 'activate' === $component_id || 'register' === $component_id ) ? esc_html_e( 'Page permalink', 'buddypress' ) : esc_html_e( 'Directory permalink', 'buddypress' ); ?>
+                                            </label>
+                                        </th>
+                                        <td>
+                                            <?php
+                                            $url_args = array(
+                                                'component_id' => $component_id,
+                                            );
+
+                                            if ( 'activate' === $component_id || 'register' === $component_id ) {
+                                                $url_args = array(
+                                                    'component_id'                        => 'members',
+                                                    sprintf( 'member_%s', $component_id ) => 1,
+                                                );
+                                            }
+
+                                            $permalink = bp_rewrites_get_url( $url_args );
+                                            ?>
+                                            <input type="text" class="code bp-directory-url" id="<?php echo esc_attr( sprintf( '%s-directory-url', sanitize_key( $component_id ) ) ); ?>" value="<?php echo esc_url( $permalink ); ?>" disabled="disabled">
+
+                                            <?php if ( 'activate' !== $component_id && 'register' !== $component_id ) : ?>
+                                                <a href="<?php echo esc_url( $permalink ); ?>" class="button-secondary bp-open-permalink" target="_bp">
+                                                    <?php esc_html_e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external" aria-hidden="true"></span>
+                                                    <span class="screen-reader-text"><?php esc_html_e( '(opens in a new tab)', 'buddypress' ); ?></span>
+                                                </a>
+                                            <?php endif; ?>
                                         </td>
                                     </tr>

trunk/src/bp-core/admin/css/common-rtl.css

@@ -16 +16 @@
     2.1 Top level menus
     2.2 Settings - Components
-    2.3 Tools
-    2.4 Tooltips
+    2.3 Settings - URls
+    2.4 Tools
+    2.5 Tooltips
 3.0 Users
     3.1 Users List
@@ -308 +309 @@
 
 /*
- * 2.3 Tools
+ * 2.3 Settings - URLs
+ */
+.settings_page_bp-rewrites .bp-directory-url {
+    width: 80%;
+    box-shadow: 0 0 0 transparent;
+    border: 1px solid #8c8f94;
+    background-color: #fff;
+    color: #2c3338;
+}
+
+.settings_page_bp-rewrites .bp-open-permalink .dashicons {
+    vertical-align: sub;
+}
+
+/*
+ * 2.4 Tools
  */
 #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
@@ -331 +347 @@
 
 /*
- * 2.4 Tooltips
+ * 2.5 Tooltips
  */
 .bp-tooltip {

trunk/src/bp-core/admin/css/common.css

@@ -16 +16 @@
     2.1 Top level menus
     2.2 Settings - Components
-    2.3 Tools
-    2.4 Tooltips
+    2.3 Settings - URls
+    2.4 Tools
+    2.5 Tooltips
 3.0 Users
     3.1 Users List
@@ -308 +309 @@
 
 /*
- * 2.3 Tools
+ * 2.3 Settings - URLs
+ */
+.settings_page_bp-rewrites .bp-directory-url {
+    width: 80%;
+    box-shadow: 0 0 0 transparent;
+    border: 1px solid #8c8f94;
+    background-color: #fff;
+    color: #2c3338;
+}
+
+.settings_page_bp-rewrites .bp-open-permalink .dashicons {
+    vertical-align: sub;
+}
+
+/*
+ * 2.4 Tools
  */
 #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
@@ -331 +347 @@
 
 /*
- * 2.4 Tooltips
+ * 2.5 Tooltips
  */
 .bp-tooltip {

trunk/src/bp-core/admin/js/rewrites-ui.js

@@ -5 +5 @@
         accordions.forEach( function( accordion ) {
             accordion.addEventListener( 'click', function( e ) {
-                e.preventDefault();
+                if ( e.target && e.target.matches( 'button.health-check-accordion-trigger' ) ) {
+                    e.preventDefault();
 
-                if ( e.target && e.target.matches( 'button.health-check-accordion-trigger' ) ) {
                     var isExpanded = ( 'true' === e.target.getAttribute( 'aria-expanded' ) ),
                         panel = document.querySelector( '#' + e.target.getAttribute( 'aria-controls' ) );