Changeset 13468 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

05/03/2023 06:18:23 AM (3 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -160 +160 @@
      *                       Possible values are `rewrites` or `legacy`.
      */
-    return apply_filters( 'bp_core_get_query_parser', bp_has_pretty_urls() ? 'legacy' : 'rewrites' );
+    return apply_filters( 'bp_core_get_query_parser', 'rewrites' );
 }
 
@@ -958 +958 @@
             $site         = get_site_by_path( $current_site->domain, trailingslashit( $current_site->path ) . $slug );
 
-            if ( isset( $site->blog_id ) && 1 !== $site->blog_id ) {
+            if ( isset( $site->blog_id ) && 1 !== (int) $site->blog_id ) {
                 $illegal_names[] = $slug;
             }
@@ -4957 +4957 @@
 
         if ( isset( $component->sub_nav ) && is_array( $component->sub_nav ) && $component->sub_nav ) {
+            // We possibly need to move some members nav items.
+            if ( 'members' === $key_component && isset( $navigations['profile']['sub_nav'] ) ) {
+                $profile_subnav_slugs = wp_list_pluck( $navigations['profile']['sub_nav'], 'slug' );
+                foreach ( $component->sub_nav as $members_subnav ) {
+                    if ( 'profile' === $members_subnav['parent_slug'] && ! in_array( $members_subnav['slug'], $profile_subnav_slugs, true ) ) {
+                        $navigations['profile']['sub_nav'][] = $members_subnav;
+                    }
+                }
+            }
+
             $navigations[ $key_component ]['sub_nav'] = $component->sub_nav;
         }