Changeset 13449 for trunk/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

04/08/2023 06:31:46 AM (22 months ago)

Author:

imath

Message:

Make sure all Groups component URLs are built using BP rewrites API

• Introduce the bp_groups_get_create_url() to ease Groups create URLs generation.
• Improve bp_groups_get_path_chunks() to deal with front-end group admin URLs and the Groups create URLs.
• Deprecate bp_get_groups_directory_permalink() in favor of bp_get_groups_directory_url().
• Replace all remaining deprecated functions usage.
• Start putting deprecated functions behind a function_exists( 'bp_classic' ) check, corresponding functions were added inside the BP Classic backcompat plugin.
• Adjust some Groups routing unit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/83
See #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (2 diffs)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -513 +513 @@
      * @param array $settings_tabs The BP Admin settings tabs.
      */
-    return apply_filters( 'bp_core_get_admin_settings_tabs', $settings_tabs );
+    $settings_tabs = apply_filters( 'bp_core_get_admin_settings_tabs', $settings_tabs );
+
+    // Sort tabs before returning it.
+    ksort( $settings_tabs );
+
+    return $settings_tabs;
 }
 
@@ -559 +564 @@
      * @param array $tools_tabs The BP Admin tools tabs.
      */
-    return apply_filters( 'bp_core_get_admin_tools_tabs', $tools_tabs );
+    $tools_tabs = apply_filters( 'bp_core_get_admin_tools_tabs', $tools_tabs );
+
+    // Sort tabs before returning it.
+    ksort( $tools_tabs );
+
+    return $tools_tabs;
 }