Changeset 13443 for trunk/src/bp-core/bp-core-buddybar.php

Timestamp:

03/31/2023 05:26:39 PM (3 years ago)

Author:

imath

Message:

Make sure all displayed user URLs are built using the BP Rewrites API

Replace all remaining bp_displayed_user_domain() usage in favor of
bp_displayed_user_url().
Introduce the bp_members_get_path_chunks() function to quickly build BP
Rewrites argument for member's URL using an array of slugs.
Deprecate bp_activities_member_rss_link(), bp_blogs_blog_tabs() &
bp_groups_header_tabs().
Improve bp_displayed_user_link() so that it's possible to pass an array
of slugs to output an escaped BP Rewrites ready URL.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/79
See #4954

File:

• trunk/src/bp-core/bp-core-buddybar.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-buddybar.php

@@ -751 +751 @@
                 if ( bp_is_my_profile() || ( isset( $parent_nav_default_item ) && $parent_nav_default_item->show_for_displayed_user ) ) {
                     $message     = __( 'You do not have access to that page.', 'buddypress' );
-                    $redirect_to = bp_displayed_user_domain();
+                    $redirect_to = bp_displayed_user_url();
 
                 // In some cases, the default tab is not accessible to
@@ -759 +759 @@
                     // Try 'activity' first.
                     if ( bp_is_active( 'activity' ) && isset( $bp->pages->activity ) ) {
-                        $redirect_to = trailingslashit( bp_displayed_user_domain() . bp_get_activity_slug() );
+                        $activity_slug = bp_get_activity_slug();
+                        $redirect_to   = bp_displayed_user_url(
+                            array(
+                                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_' . $activity_slug, $activity_slug ),
+                            )
+                        );
                     // Then try 'profile'.
                     } else {
-                        $redirect_to = trailingslashit( bp_displayed_user_domain() . ( 'xprofile' == $bp->profile->id ? 'profile' : $bp->profile->id ) );
+                        $profile_slug  = bp_get_profile_slug();
+                        $redirect_to   = bp_displayed_user_url(
+                            array(
+                                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug, $profile_slug ),
+                            )
+                        );
                     }
 
-                    $message     = '';
+                    $message = '';
                 }