Changeset 13437 for trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php

Timestamp:

03/18/2023 09:42:31 AM (21 months ago)

Author:

imath

Message:

BP Rewrites: start the migration process for the Groups component

• Add rewrite tags & rules for the Groups directory type and the create URLs.
• Introduce bp_get_group_url()/bp_group_url() & to retrieve/output a Groups single item URL using BP Rewrites.
• Introduce bp_get_group_restricted_screens(), bp_get_group_extension_screens() & bp_get_group_screens() to get information about the Groups screens (in particular each screen rewrite ID). These functions will ease slug customizations from the BuddyPress URL settings tab.
• Improve the Group creation process making sure it's using BP Rewrites to build URLs.
• Perform easiest replacements for bp_get_group_permalink()/bp_group_permalink() & bp_get_groups_directory_permalink()/bp_groups_directory_permalink() in favor of bp_get_group_url()/bp_group_url() & bp_get_groups_directory_url()/bp_groups_directory_url()`.
• Improve code formatting & properly escape single group URLs into templates.
• Update impacted Unit Tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/75
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php

@@ -171 +171 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u );
+        $this->set_permalink_structure( '/%postname%/' );
 
         $group = groups_get_group( $g );
 
-        $this->go_to( bp_get_group_permalink( $group ) );
-
-        $subnav_item = array(
-            'user_has_access' => false,
-            'no_access_url' => bp_get_group_permalink( $group ),
-        );
-
-        // Just test relevant info
-        $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
-        $this->assertSame( 'failure', $found['status'] );
-        $this->assertSame( bp_get_group_permalink( $group ), $found['redirect_args']['root'] );
+        $this->go_to( bp_get_group_url( $group ) );
+
+        $subnav_item = array(
+            'user_has_access' => false,
+            'no_access_url' => bp_get_group_url( $group ),
+        );
+
+        // Just test relevant info
+        $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
+        $this->assertSame( 'failure', $found['status'] );
+        $this->assertSame( bp_get_group_url( $group ), $found['redirect_args']['root'] );
 
         // Clean up
@@ -198 +199 @@
         $group = groups_get_group( $g );
 
-        $this->go_to( bp_get_group_permalink( $group ) );
+        $this->go_to( bp_get_group_url( $group ) );
 
         $subnav_item = array(