Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/18/2023 09:42:31 AM (13 months ago)
Author:
imath
Message:

BP Rewrites: start the migration process for the Groups component

  • Add rewrite tags & rules for the Groups directory type and the create URLs.
  • Introduce bp_get_group_url()/bp_group_url() & to retrieve/output a Groups single item URL using BP Rewrites.
  • Introduce bp_get_group_restricted_screens(), bp_get_group_extension_screens() & bp_get_group_screens() to get information about the Groups screens (in particular each screen rewrite ID). These functions will ease slug customizations from the BuddyPress URL settings tab.
  • Improve the Group creation process making sure it's using BP Rewrites to build URLs.
  • Perform easiest replacements for bp_get_group_permalink()/bp_group_permalink() & bp_get_groups_directory_permalink()/bp_groups_directory_permalink() in favor of bp_get_group_url()/bp_group_url() & bp_get_groups_directory_url()/bp_groups_directory_url()`.
  • Improve code formatting & properly escape single group URLs into templates.
  • Update impacted Unit Tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/75
See #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php

    r13436 r13437  
    171171        $old_current_user = get_current_user_id();
    172172        $this->set_current_user( $u );
     173        $this->set_permalink_structure( '/%postname%/' );
    173174
    174175        $group = groups_get_group( $g );
    175176
    176         $this->go_to( bp_get_group_permalink( $group ) );
    177 
    178         $subnav_item = array(
    179             'user_has_access' => false,
    180             'no_access_url' => bp_get_group_permalink( $group ),
    181         );
    182 
    183         // Just test relevant info
    184         $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
    185         $this->assertSame( 'failure', $found['status'] );
    186         $this->assertSame( bp_get_group_permalink( $group ), $found['redirect_args']['root'] );
     177        $this->go_to( bp_get_group_url( $group ) );
     178
     179        $subnav_item = array(
     180            'user_has_access' => false,
     181            'no_access_url' => bp_get_group_url( $group ),
     182        );
     183
     184        // Just test relevant info
     185        $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
     186        $this->assertSame( 'failure', $found['status'] );
     187        $this->assertSame( bp_get_group_url( $group ), $found['redirect_args']['root'] );
    187188
    188189        // Clean up
     
    198199        $group = groups_get_group( $g );
    199200
    200         $this->go_to( bp_get_group_permalink( $group ) );
     201        $this->go_to( bp_get_group_url( $group ) );
    201202
    202203        $subnav_item = array(
Note: See TracChangeset for help on using the changeset viewer.