Changeset 13433 for trunk/tests/phpunit/testcases/members/functions.php

Timestamp:

03/07/2023 04:28:08 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/members/functions.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/members/functions.php

@@ -5 +5 @@
 #[AllowDynamicProperties]
 class BP_Tests_Members_Functions extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
 
     /**
@@ -114 +126 @@
      * @group bp_core_get_directory_pages
      */
-    public function test_bp_core_get_user_domain_after_directory_page_update() {
+    public function test_bp_members_get_user_url_after_directory_page_update() {
         // Generate user
         $user_id = self::factory()->user->create( array( 'role' => 'subscriber' ) );
+        $this->set_permalink_structure( '/%postname%/' );
 
         // Set object cache first for user domain
-        $user_domain = bp_core_get_user_domain( $user_id );
+        $user_domain = bp_members_get_user_url( $user_id );
 
         // Now change the members directory slug
@@ -137 +150 @@
         $user = new WP_User( $user_id );
 
-        $this->assertSame( home_url( $new_members_slug ) . '/' . $user->user_nicename . '/', bp_core_get_user_domain( $user_id ) );
+        $this->assertSame( home_url( $new_members_slug ) . '/' . $user->user_nicename . '/', bp_members_get_user_url( $user_id ) );
     }