Changeset 13432 for trunk/src/bp-members/bp-members-functions.php

Timestamp:

03/01/2023 08:17:11 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-members/bp-members-functions.php (modified) (2 diffs)

trunk/src/bp-members/bp-members-functions.php

@@ -25 +25 @@
     return (bool) ! empty( $bp->pages->members->id );
 }
-
-/**
- * Define the slug constants for the Members component.
- *
- * Handles the three slug constants used in the Members component -
- * BP_MEMBERS_SLUG, BP_REGISTER_SLUG, and BP_ACTIVATION_SLUG. If these
- * constants are not overridden in wp-config.php or bp-custom.php, they are
- * defined here to match the slug of the corresponding WP pages.
- *
- * In general, fallback values are only used during initial BP page creation,
- * when no slugs have been explicitly defined.
- *
- * @since 1.5.0
- */
-function bp_core_define_slugs() {
-    $bp = buddypress();
-
-    // No custom members slug.
-    if ( !defined( 'BP_MEMBERS_SLUG' ) ) {
-        if ( !empty( $bp->pages->members ) ) {
-            define( 'BP_MEMBERS_SLUG', $bp->pages->members->slug );
-        } else {
-            define( 'BP_MEMBERS_SLUG', 'members' );
-        }
-    }
-
-    // No custom registration slug.
-    if ( !defined( 'BP_REGISTER_SLUG' ) ) {
-        if ( !empty( $bp->pages->register ) ) {
-            define( 'BP_REGISTER_SLUG', $bp->pages->register->slug );
-        } else {
-            define( 'BP_REGISTER_SLUG', 'register' );
-        }
-    }
-
-    // No custom activation slug.
-    if ( !defined( 'BP_ACTIVATION_SLUG' ) ) {
-        if ( !empty( $bp->pages->activate ) ) {
-            define( 'BP_ACTIVATION_SLUG', $bp->pages->activate->slug );
-        } else {
-            define( 'BP_ACTIVATION_SLUG', 'activate' );
-        }
-    }
-}
-add_action( 'bp_setup_globals', 'bp_core_define_slugs', 11 );
 
 /**
@@ -1548 +1503 @@
     );
 
-    // Core constants.
+    // @todo replace slug constants with custom slugs.
     $slug_constants = array(
-        'BP_GROUPS_SLUG',
-        'BP_MEMBERS_SLUG',
         'BP_FORUMS_SLUG',
-        'BP_BLOGS_SLUG',
-        'BP_ACTIVITY_SLUG',
-        'BP_XPROFILE_SLUG',
-        'BP_FRIENDS_SLUG',
         'BP_SEARCH_SLUG',
-        'BP_SETTINGS_SLUG',
-        'BP_NOTIFICATIONS_SLUG',
-        'BP_REGISTER_SLUG',
-        'BP_ACTIVATION_SLUG',
     );
     foreach ( $slug_constants as $constant ) {