Changeset 13312 for trunk/src/bp-activity/classes/class-bp-activity-activity.php

Timestamp:

08/13/2022 08:21:06 AM (3 years ago)

Author:

imath

Message:

Avoid various PHP 8.1 deprecated notices

Here are the treated deprecated notices:

• ctype_digit() Argument of type int will be interpreted as string in the future.
• Automatic conversion of false to array.
• Passing null to strtotime() $datetime parameter.

Props renatonascalves, rafiahmedd

See #8649

File:

• trunk/src/bp-activity/classes/class-bp-activity-activity.php (modified) (4 diffs)

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -1241 +1241 @@
         );
 
-        $where_args = false;
+        $where_args = array();
 
         if ( ! empty( $r['user_id'] ) ) {
@@ -1568 +1568 @@
         }
 
-        $comments = wp_cache_get( $activity_id, 'bp_activity_comments' );
+        $comments       = array();
+        $comments_cache = wp_cache_get( $activity_id, 'bp_activity_comments' );
 
         // We store the string 'none' to cache the fact that the
         // activity item has no comments.
-        if ( 'none' === $comments ) {
-            $comments = false;
+        if ( 'none' === $comments_cache ) {
+            return false;
 
             // A true cache miss.
-        } elseif ( empty( $comments ) ) {
+        } elseif ( empty( $comments_cache ) ) {
 
             $bp = buddypress();
@@ -1690 +1691 @@
             }
 
-            // If we cache a value of false, it'll count as a cache
+            // If we cache an empty array, it'll count as a cache
             // miss the next time the activity comments are fetched.
             // Storing the string 'none' is a hack workaround to
             // avoid unnecessary queries.
-            if ( false === $comments ) {
+            if ( ! $comments ) {
                 $cache_value = 'none';
             } else {
@@ -1701 +1702 @@
 
             wp_cache_set( $activity_id, $cache_value, 'bp_activity_comments' );
+        } else {
+            $comments = (array) $comments_cache;
         }