Changeset 13035 for trunk/tests/phpunit/testcases/messages/notifications.php

Timestamp:

08/10/2021 04:16:30 PM (3 years ago)

Author:

imath

Message:

Make the new_message notification filter consistent across formats

The 'bp_messages_' . $amount . '_new_message_notification' dynamic filter is including 6 parameters for the string format and 7 for the array format. This makes it difficult to use for Plugin developers.

To make things more consistent across formats, we are deprecating this filter in favor of a new dynamic filter 'bp_messages_' . $amount . '_new_message_' . $format . '_notification'. FYI, possible filter names are:

• 'bp_messages_multiple_new_message_string_notification'
• 'bp_messages_single_new_message_string_notification'
• 'bp_messages_multiple_new_message_array_notification'
• 'bp_messages_single_new_message_array_notification'

Fixes #8546

File:

• trunk/tests/phpunit/testcases/messages/notifications.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/messages/notifications.php

@@ -32 +32 @@
         ) );
 
-        add_filter( 'bp_messages_multiple_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        add_filter( 'bp_messages_multiple_new_message_array_notification', array( $this, 'notification_filter_callback' ) );
         $n = messages_format_notifications( 'new_message', $n, '', 2, 'array' );
-        remove_filter( 'bp_messages_multiple_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        remove_filter( 'bp_messages_multiple_new_message_array_notification', array( $this, 'notification_filter_callback' ) );
 
-        $this->assertSame( 'bp_messages_multiple_new_message_notification', $this->filter_fired );
+        $this->assertSame( 'bp_messages_multiple_new_message_array_notification', $this->filter_fired );
     }
 
     /**
      * @group messages_format_notifications
+     * @group imath
      */
     public function test_friends_format_notifications_bp_messages_single_new_message_notification_nonstring_filter() {
@@ -56 +57 @@
         ) );
 
-        add_filter( 'bp_messages_single_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        add_filter( 'bp_messages_single_new_message_array_notification', array( $this, 'notification_filter_callback' ) );
         $n = messages_format_notifications( 'new_message', $n, '', 1, 'array' );
-        remove_filter( 'bp_messages_single_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        remove_filter( 'bp_messages_single_new_message_array_notification', array( $this, 'notification_filter_callback' ) );
 
-        $this->assertSame( 'bp_messages_single_new_message_notification', $this->filter_fired );
+        $this->assertSame( 'bp_messages_single_new_message_array_notification', $this->filter_fired );
     }
 
@@ -80 +81 @@
         ) );
 
-        add_filter( 'bp_messages_multiple_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        add_filter( 'bp_messages_multiple_new_message_string_notification', array( $this, 'notification_filter_callback' ) );
         $n = messages_format_notifications( 'new_message', $n, '', 2 );
-        remove_filter( 'bp_messages_multiple_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        remove_filter( 'bp_messages_multiple_new_message_string_notification', array( $this, 'notification_filter_callback' ) );
 
-        $this->assertSame( 'bp_messages_multiple_new_message_notification', $this->filter_fired );
+        $this->assertSame( 'bp_messages_multiple_new_message_string_notification', $this->filter_fired );
     }
 
@@ -104 +105 @@
         ) );
 
-        add_filter( 'bp_messages_single_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        add_filter( 'bp_messages_single_new_message_string_notification', array( $this, 'notification_filter_callback' ) );
         $n = messages_format_notifications( 'new_message', $n, '', 1 );
-        remove_filter( 'bp_messages_single_new_message_notification', array( $this, 'notification_filter_callback' ) );
+        remove_filter( 'bp_messages_single_new_message_string_notification', array( $this, 'notification_filter_callback' ) );
 
-        $this->assertSame( 'bp_messages_single_new_message_notification', $this->filter_fired );
+        $this->assertSame( 'bp_messages_single_new_message_string_notification', $this->filter_fired );
     }