Changeset 12772 for trunk/tests/phpunit/testcases/blogs/template.php

Timestamp:

10/30/2020 10:13:38 PM (4 years ago)

Author:

imath

Message:

Blogs: use a default "blavatar" when the blog has no site icon

So far when the Blogs component was not supporting the WordPress site icon feature or when the blog had no site icon set, we used to fallback on the Blog Administrator's avatar.

We realized this was a wrong approach, because:

• the site creator may no longer be a member of the specific site, in which case the lowest id will belong to a different (non-admin) user.
• The site admin may have changed in some other way.
• The site creator's account may have been deleted.
• Etc.

When any of these happen, you get the avatar of a random site user.

That's why just like we do for users or groups, we are now using a default blog avatar (mysterious-blog.png) as a fallback when the site icon for the blog is not available.

Props boonebgorges, vapvarun, johnjamesjacoby

Fixes #8179

File:

• trunk/tests/phpunit/testcases/blogs/template.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/blogs/template.php

@@ -398 +398 @@
 
         $blogs_template = $reset_blogs_template;
-
-        $this->assertTrue( $avatar === bp_core_fetch_avatar( array(
-            'type'          => 'full',
-            'item_id'       => $u,
-            'alt'           => 'test',
-            'no_grav'       => true,
-            'class'         => 'avatar',
-        ) ) );
+        $expected       = bp_core_fetch_avatar(
+            array(
+                'type'    => 'full',
+                'item_id' => $u,
+                'alt'     => 'test',
+                'no_grav' => true,
+                'class'   => 'avatar',
+            )
+        );
+
+        $this->assertTrue( $avatar === $expected );
     }
 
@@ -445 +448 @@
     }
 
+    /**
+     * @group avatar
+     * @group BP_Blogs_Template
+     * @group bp_get_blog_avatar
+     */
+    public function test_bp_get_blog_default_avatar() {
+        if ( ! is_multisite() ) {
+            $this->markTestSkipped();
+        }
+
+        global $blogs_template;
+        $reset_blogs_template = $blogs_template;
+        $blogs_template = null;
+
+        $u = self::factory()->user->create();
+        $b = self::factory()->blog->create( array(
+            'title' => 'The Foo Bar Blog',
+            'user_id' => $u,
+        ) );
+
+        $avatar = bp_get_blog_avatar(
+            array(
+                'type'    => 'thumb',
+                'blog_id' => $b,
+                'html'    => false,
+            )
+        );
+
+        $blogs_template = $reset_blogs_template;
+        $expected       = buddypress()->plugin_url . "bp-core/images/mystery-blog-50.png";
+
+        $this->assertTrue( $avatar === $expected );
+    }
+
     public function filter_blog_avatar() {
         return BP_TESTS_DIR . 'assets/upside-down.jpg';