Changeset 11611 for trunk/src/bp-members/bp-members-functions.php

Timestamp:

06/23/2017 05:32:04 PM (8 years ago)

Author:

r-a-y

Message:

Members: Cache invalid users in bp_core_get_core_userdata().

This commit caches non-existent user attempts for the
bp_core_get_core_userdata() function, so subsequent calls for the same
user ID will not ping the database again.

See #7523.

File:

• trunk/src/bp-members/bp-members-functions.php (modified) (3 diffs)

trunk/src/bp-members/bp-members-functions.php

@@ -207 +207 @@
  * @since 1.2.0
  *
- * @param int $user_id The ID of the user.
- * @return array
+ * @param  int $user_id The ID of the user.
+ * @return array|bool Array of data on success, boolean false on failure.
  */
 function bp_core_get_core_userdata( $user_id = 0 ) {
@@ -215 +215 @@
     }
 
-    if ( !$userdata = wp_cache_get( 'bp_core_userdata_' . $user_id, 'bp' ) ) {
+    $userdata = wp_cache_get( 'bp_core_userdata_' . $user_id, 'bp' );
+
+    // No cache.
+    if ( false === $userdata ) {
         $userdata = BP_Core_User::get_core_userdata( $user_id );
-        wp_cache_set( 'bp_core_userdata_' . $user_id, $userdata, 'bp' );
+
+        // Cache data; no-result is cached as integer 0.
+        wp_cache_set( 'bp_core_userdata_' . $user_id, false === $userdata ? 0 : $userdata, 'bp' );
+
+    // Cached no-result, so set return value as false as expected.
+    } elseif ( 0 === $userdata ) {
+        $userdata = false;
     }
 
@@ -225 +234 @@
      * @since 1.2.0
      *
-     * @param array $userdata Array of user data for a passed user.
+     * @param array|bool $userdata Array of user data for a passed user on success, boolean false on failure.
      */
     return apply_filters( 'bp_core_get_core_userdata', $userdata );