Changeset 11525

Timestamp:

04/05/2017 12:20:01 AM (8 years ago)

Author:

dcavins

Message:

Use BP_Groups_Group::get() in BP_Groups_Group::group_exists()

Retire the one-off, direct database query in
BP_Groups_Group::group_exists() in favor of using
`BP_Groups_Group::get()’ internally. Also, the new form takes advantage
of the built-in incremented caching in `BP_Groups_Group::get()’.

Fixes #7477.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -613 +613 @@
      *
      * @param string      $slug       Slug to check.
-     * @param string|bool $table_name Optional. Name of the table to check
-     *                                against. Default: $bp->groups->table_name.
+     * @param string|bool $table_name Deprecated.
      * @return int|null Group ID if found; null if not.
      */
@@ -620 +619 @@
         global $wpdb;
 
-        if ( empty( $table_name ) )
-            $table_name = buddypress()->groups->table_name;
-
-        if ( empty( $slug ) )
+        if ( empty( $slug ) ) {
             return false;
-
-        $query = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$table_name} WHERE slug = %s", strtolower( $slug ) ) );
-
-        return is_numeric( $query ) ? (int) $query : $query;
+        }
+
+        $args = array(
+            'slug'               => $slug,
+            'per_page'           => 1,
+            'page'               => 1,
+            'update_meta_cache'  => false,
+            'show_hidden'        => true,
+        );
+
+        $groups = BP_Groups_Group::get( $args );
+
+        $group_id = null;
+        if ( $groups['groups'] ) {
+            $group_id = current( $groups['groups'] )->id;
+        }
+
+        return $group_id;
     }