Changeset 11526

Timestamp:

04/05/2017 08:04:10 PM (9 years ago)

Author:

boonebgorges

Message:

Specify that group admin/mod queries should be blog-independent.

On Multisite, get_users() queries are limited to the current site, unless
otherwise specified. Since group membership is independent of WP site
roles/caps, we should opt out of this limitation.

Fixes #7497.

Location:

trunk

Files:

• src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)
• tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -536 +536 @@
         $admin_mod_users = get_users( array(
             'include' => array_merge( $admin_ids_plucked, $mod_ids_plucked ),
+            'blog_id' => null,
         ) );
 

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -1449 +1449 @@
 
     /**
+     * @ticket BP7497
+     */
+    public function test_admins_property_should_match_users_without_wp_role() {
+        $user_1 = $this->factory->user->create_and_get();
+        $g = $this->factory->group->create( array(
+            'creator_id' => $user_1->ID,
+        ) );
+
+        $user_1->remove_all_caps();
+
+        $group = new BP_Groups_Group( $g );
+
+        $this->assertEqualSets( array( $user_1->ID ), wp_list_pluck( $group->admins, 'user_id' ) );
+    }
+
+    /**
      * @ticket BP5451
      */